Rust 1.39 Update + Spring Cleaning

.cargo/config

@@ -1,5 +1,6 @@
 [build]
 target = "x86_64-unknown-linux-musl"
+target-dir = "build/cargo_target"
 
 [target.'cfg(any(target_arch="arm", target_arch="aarch64"))']
 # On aarch64 musl depends on some libgcc functions (i.e `__addtf3` and other `*tf3` functions) for logic that uses

.github/pull_request_template.md

@@ -13,12 +13,12 @@ the terms of the Apache 2.0 license.
 
 ## PR Checklist
 
-`[Author TODO: Meet these criteria. Where there are two options, keep one.]`  
+`[Author TODO: Meet these criteria. Where there are two options, keep one.]`
 `[Reviewer TODO: Verify that these criteria are met. Request changes if not]`
 
 - [ ] All commits in this PR are signed (`git commit -s`).
 - [ ] Either this PR is linked to an issue, or, the reason for this PR is
-      clearly provided. 
+      clearly provided.
 - [ ] The description of changes is clear and encompassing.
 - [ ] Either no docs need to be updated as part of this PR, or, the required
       doc changes are included in this PR. Docs in scope are all `*.md` files

CODE_OF_CONDUCT.md

@@ -3,6 +3,6 @@
 This project has adopted the
 [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
 For more information see the
-[Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact 
+[Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
 [[email protected]](mailto:[email protected])
 with any additional questions or comments.

CONTRIBUTING.md

@@ -23,7 +23,7 @@ commit-based feedback for a contribution, follow the
 Firecracker uses the “fork-and-pull” development model. Follow these steps if
 you want to merge your changes to Firecracker:
 
-1. Within your fork of 
+1. Within your fork of
    [Firecracker](https://github.com/firecracker-microvm/firecracker), create a
    branch for your contribution. Use a meaningful name.
 1. Create your contribution, meeting all
@@ -43,7 +43,7 @@ you want to merge your changes to Firecracker:
 If you just want to receive feedback for a contribution proposal, open an “RFC”
 (“Request for Comments”) pull request:
 
-1. On your fork of 
+1. On your fork of
    [Firecracker](https://github.com/firecracker-microvm/firecracker), create a
    branch for the contribution you want feedback on. Use a meaningful name.
 1. Create your proposal based on the existing codebase.
@@ -74,4 +74,3 @@ testing. Your contribution needs to meet the following standards:
   part of your contribution contravenes this license by signing off on all your
   commits with `git -s`. Ensure that every file in your pull request has a
   header referring to the repository license file.
-

Cargo.toml

@@ -1,30 +1,9 @@
-[package]
-name = "firecracker"
-version = "0.19.0"
-authors = ["Amazon Firecracker team <[email protected]>"]
-
-[dependencies]
-backtrace = {version = "=0.3.35", features = ["libunwind", "libbacktrace", "std"], default-features = false}
-clap = { version = ">=2.27.1", default-features = false}
-
-api_server = { path = "api_server" }
-jailer = { path = "jailer" }
-logger = { path = "logger" }
-mmds = { path = "mmds" }
-seccomp = { path = "seccomp" }
-utils = { path = "utils" }
-vmm = { path = "vmm" }
-libc = ">=0.2.39"
-
-
-[dev-dependencies]
-tempfile = ">=3.0.2"
+[workspace]
+members = ["src/firecracker", "src/jailer"]
 
 [profile.dev]
 panic = "abort"
 
 [profile.release]
-lto = true
 panic = "abort"
-
-[workspace]
+lto = true

FAQ.md

@@ -168,7 +168,7 @@ You can see more info about the `refclock` parameters
 [here](https://chrony.tuxfamily.org/doc/3.4/chrony.conf.html#refclock).
 Adjust them according to your needs.
 
-### Each Firecracker opens 20+ file descriptors. Is this an issue?  
+### Each Firecracker opens 20+ file descriptors. Is this an issue?
 
 The relatively high FD usage is expected and correct. Firecracker heavily
 relies on event file descriptors to drive device emulation.
@@ -230,7 +230,7 @@ Possible mitigations are:
 
 ### How can I configure and start a microVM without sending API calls?
 
-Passing an optional command line parameter, `--config-file`, to the Firecracker 
-process allows this type of configuration. This parameter must be the path to a 
-file that contains the JSON specification that will be used to configure and start 
-the microVM. One example of such file can be found at `tests/framework/vm_config.json`. 
+Passing an optional command line parameter, `--config-file`, to the Firecracker
+process allows this type of configuration. This parameter must be the path to a
+file that contains the JSON specification that will be used to configure and start
+the microVM. One example of such file can be found at `tests/framework/vm_config.json`.

MAINTAINERS.md

@@ -9,4 +9,3 @@ Firecracker is maintained by a dedicated team within Amazon:
 - Dan Horobeanu <[email protected]>
 - Diana Popa <[email protected]>
 - Andreea Florescu <[email protected]>
-

NOTICE

@@ -1,2 +1,2 @@
 Firecracker
-Copyright 2017-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. 
+Copyright 2017-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.

SECURITY-POLICY.md

@@ -20,4 +20,3 @@ vulnerability during the embargo period.
 
 At the end of the embargo period, maintainers will publicly release information
 about the vulnerability together with the Firecracker patches that mitigate it.
-

SPECIFICATION.md

@@ -58,4 +58,3 @@ enough RAM, etc.), customers can rely on the following:
 ³ No logs are currently produced in the span of time between the `jailer`
   process start-up and the logging system initialization in the `firecracker`
   process.
-