Skip to content

Reintroduce to_petsc_local_numbering #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Conversation

jwallwork23
Copy link
Contributor

Hi all. I decided to take the metric-based mesh adaptation stuff out of #2796 and put it in a new repo: https://github.com/pyroteus/animate. However, it will still need the to_petsc_local_numbering function that was removed from Firedrake at some point. Would you be willing to put this updated version back in?

The PR also contains some minor fixes for the PETSc interface docs (introduced by me I think).

ksagiyam
ksagiyam previously approved these changes Aug 14, 2023
Copy link
Contributor

@ksagiyam ksagiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just had some suggestions for the docstring.

Thanks to @ksagiyam

Co-authored-by: ksagiyam <[email protected]>
@jwallwork23 jwallwork23 requested a review from ksagiyam August 14, 2023 18:03
@ksagiyam ksagiyam merged commit 7c3574c into master Aug 14, 2023
@ksagiyam ksagiyam deleted the jwallwork23/petsc-interface branch August 14, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants