checkpointing bcs #4284
Merged
checkpointing bcs #4284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To fix CI I think you need to rebase on top of current |
pbrubeck
reviewed
May 7, 2025
Co-authored-by: Pablo Brubeck <[email protected]>
pbrubeck
reviewed
May 7, 2025
dham
approved these changes
May 7, 2025
|
It still seems like this should pass the CI. It would be nice to see it merged to help unblock us a bit, if that's possible? |
angus-g
pushed a commit
that referenced
this pull request
Jun 4, 2025
Ensure that restoring a BC from checkpoint returns a new BC and doesn't incorrectly modify the program variable BC. --------- Co-authored-by: David A. Ham <[email protected]> Co-authored-by: Pablo Brubeck <[email protected]>
connorjward
pushed a commit
that referenced
this pull request
Jun 4, 2025
Ensure that restoring a BC from checkpoint returns a new BC and doesn't incorrectly modify the program variable BC. --------- Co-authored-by: Daiane Iglesia Dolci <[email protected]> Co-authored-by: David A. Ham <[email protected]> Co-authored-by: Pablo Brubeck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles the issue with the incorrect checkpointing of Dirichlet boundary conditions. Currently, during tape recomputation, the user-defined boundary condition (
DirichletBC._original_arg) is being updated. This leads to the issue #4206.In that issue, James suggested an approach to checkpoint the Dirichlet boundary condition. This PR implements that suggestion and includes a test to verify the fix.
This change fixes issue #4206.