Set up ESLint

[tobyzerner]

http://eslint.org/

Need to discuss style rules we want to use.

[tobyzerner]

@franzliedke and I discussed and have decided to use the Airbnb preset with as little modification as possible.

[sijad]

isn't https://github.com/airbnb/javascript/blob/master/linters/.eslintrc?
if you still have plan to use airbnb. a few dev dependencies should be added to flarum-gulp tough.

[dav-is]

I found this config works well with Flarum:

{
    "extends": "eslint-config-airbnb",
    "rules": {
        "import/no-unresolved": "off",
        "import/no-extraneous-dependencies": "off",
        "import/extensions": ["error", "never"],
        "react/jsx-filename-extension": ["error", { "extensions": [".js"] }],
        "react/react-in-jsx-scope": "off",
        "react/prop-types": "off",
        "react/sort-comp": ["error", {
          order: [
            "/^constructor$/",
            "/^init$/",
            "/^initProps$/",
            "static-methods",
            "/^content$/",
            "/^view$/",
            "/^config$/",
            "everything-else",
            "/^onsubmit$/",
            "/^onerror$/"
          ]
        }]
    },
    "env": {
            "jquery": true,
        "browser": true
        },
    "globals": [
            "app",
            "m"
        ]
}

(Edited)

[sijad]

here's mine: https://github.com/sijad/flarum-ext-links/blob/master/.eslintrc
probably out of date

[sijad]

jsx-filename-extension.md consider #1030

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[franzliedke]

We have decided we want to adopt prettier instead of eslint and will do so as part of (?) the frontend rewrite.