Add ESLint #3
Add ESLint #3
Conversation
| var concat = require('gulp-concat'); | ||
| var babel = require('gulp-babel'); | ||
| var cached = require('gulp-cached'); | ||
| var remember = require('gulp-remember'); | ||
| var order = require('gulp-order'); | ||
| var streamqueue = require('streamqueue'); | ||
| var file = require('gulp-file'); | ||
| var gulpIf = require('gulp-if'); | ||
| var gulpTap = require("gulp-tap"); |
There was a problem hiding this comment.
Please use single quotes here for consistency.
| var babelCore = require('babel-core'); | ||
|
|
||
| function handleError(e) { | ||
| console.log(e.toString()); | ||
| this.emit('end'); | ||
| } | ||
| function isFixed (file) { |
There was a problem hiding this comment.
Please remove the space before the opening parenthesis.
| "/^onsubmit$/", | ||
| "/^onerror$/" | ||
| ] | ||
| }] |
There was a problem hiding this comment.
Can you explain what all of these do? Especially the order array isn't particularly self-explanatory.
There was a problem hiding this comment.
The order is the order methods must come in classes. I looked for the most common pattern for methods and came up with this order. As for the rest, the documentation explains it better than I could.
|
@tobscure You'll have to take care of this one. |
|
One of the rules that I wasn't sure to turn on or off was defining methods as statics if they don't use |
|
This package is now obsolete, in favor of flarum-webpack-config, right? Let's archive this then... @tobscure |
Added Eslint. Rules still need some discussion
flarum/framework#879