gas price adder & priority fee bugfix #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Was seeing a lot of "replacement transaction underpriced" errors.
Solution
Started by adding a mechanism to automatically increase the gas price when we saw the error. The spammer increased the gas price a ton yet I still saw the error, which led me to find an inconspicuous bug in the priority fee calculation.
With that fixed, gas price increases happened much less frequently. They still happen, though, so every time contender sees an "underpriced" error, it increases the gas price for following txs by 10%. When a batch of transactions is sent without error, the gas price for the following batch is decreased by 10%. This ensures we can keep running the spammer for a long time without the gas booster going exponential.
spamd
now reliably fills blocks on a live testnet until the accounts run out of gas, at which point contender must be manually stopped.Future improvement
In
spamd
, automatically replenish funds in agent accountsPR Checklist