feat: add timer warning on contract deployment #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroXbrock
reviewed
Apr 16, 2025
crates/cli/src/commands/setup.rs
Outdated
| } | ||
|
|
||
| let timekeeper_handle = tokio::spawn(async { | ||
| tokio::time::sleep(Duration::from_secs(10)).await; |
There was a problem hiding this comment.
Instead of locking in 10 seconds, could we wait for (num_deployments + 10) blocks? 10 seconds will make sense on devnets, but on live testnets with 12-second blocks, this will probably be confusing.
We can still use a timer; we just need to derive the block time (we've done this once already here: https://github.com/flashbots/contender/blob/main/crates/core/src/test_scenario.rs#L134-L144)
There was a problem hiding this comment.
Got it
Pushed a fix...do let me know if that was the intended direction.
This was referenced May 14, 2025
Merged
This was referenced May 23, 2025
Merged
Merged
This was referenced May 30, 2025
Merged
Merged
This was referenced Jul 14, 2025
Merged
This was referenced Aug 14, 2025
Merged
Merged
This was referenced Aug 28, 2025
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #149
Adds a log in case contract deployment takes >10secs
Solution
Adds a log in case contract deployment takes >10secs
Should ideally use
infoorwarnfromtracingcrate. Will add it if advised by maintainersPR Checklist