Skip to content

Feat/more metrics #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Apr 23, 2025
Merged

Feat/more metrics #181

merged 33 commits into from
Apr 23, 2025

Conversation

zeroXbrock
Copy link
Member

@zeroXbrock zeroXbrock commented Apr 18, 2025 •
edited
Loading

Motivation

  • measure RPC response latency
  • more metrics in report

Solution

  • hook prometheus into middleware on provider
  • save prometheus results to DB for reports
  • sick styles by @deadpine

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

zeroXbrock and others added 25 commits April 16, 2025 13:17
@zeroXbrock
dynamically size trace_data mpsc channels
abdde8a
@zeroXbrock
fix timestamp bug in pending_txs chart
594045a
@zeroXbrock
add a few simple metrics to report data, simplify block_trace.rs
35be71b
@zeroXbrock
cleanup provider & test_scenario; prepare for latency metrics
4836abc
@zeroXbrock
add prometheus registry & measure latency from provider middleware
cab9a93
@zeroXbrock
save latency data to DB
a4d0bbe
@zeroXbrock
reorganize testfile crate
02cf31c
@zeroXbrock
rename overly-specific function
4375e31
@zeroXbrock
remove unnecessary trait method
41fb8c5
@zeroXbrock
add latency chart to report
2c9b81d
@zeroXbrock
Merge branch 'main' into feat/more-metrics
3416913
@zeroXbrock
switch to HistogramVec & replace BTreeMap w/ Vec<(f64, u64)>
0c1249c
@zeroXbrock
improve latency chart & internal metrics API
af5a481 
- track latency metrics for all RPC methods
- metrics can be looked up by method name
@zeroXbrock
generalize 'tx latency' to 'rpc latency', DRY out report()
04337b4
@zeroXbrock
replace (f64, u64) with Bucket where useful, add latency quantiles to…
ed37cb6 
… Metrics
@zeroXbrock
(DRAFT) include rpc latency quantiles in report
5e9111e
@zeroXbrock
close section tag
e0c8f31
@zeroXbrock
use thicker lines in rpc latency chart
593dca5
@zeroXbrock
put rpc latency p-values in a table
eae03cb
@zeroXbrock
replace confusing lines on latency chart
7b9e539
@zeroXbrock
add rpc_url to runs table
db6f667 
- this will allow us to remove the RPC_URL param requirement from report
  cli
@zeroXbrock
use rpc_url from runs table in report, remove unneeded cli arg, fix p…
78857b3 
…rio fees in various places
@deadpine
WIP - Update new sections design (#184)
bf55cf6 
* update table

* fix <section> element

* fix fonts

* add a bigger margin below date element

* make section width bigger

* reorder sections

* update metrics design
@zeroXbrock
simplify run deploy prompt
e939456
@zeroXbrock
Merge branch 'main' into feat/more-metrics
68dd979
@zeroXbrock zeroXbrock marked this pull request as ready for review April 23, 2025 20:15
@zeroXbrock zeroXbrock requested a review from sukoneck as a code owner April 23, 2025 20:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025 •
edited
Loading

Preview Report

An example contender report preview is available here.

@zeroXbrock zeroXbrock merged commit 622779c into main Apr 23, 2025
8 checks passed
@zeroXbrock zeroXbrock deleted the feat/more-metrics branch April 23, 2025 22:21
This was referenced May 14, 2025
Closed
Merged
Merged
Merged
This was referenced May 23, 2025
Merged
Merged
Closed
Merged
Open
This was referenced May 30, 2025
Open
Merged
@github-actions github-actions bot mentioned this pull request Jun 18, 2025
Merged
This was referenced Jul 14, 2025
Open
Merged
This was referenced Aug 14, 2025
Merged
Merged
This was referenced Aug 28, 2025
Merged
Closed
This was referenced Sep 4, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sukoneck sukoneck Awaiting requested review from sukoneck sukoneck is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zeroXbrock @deadpine