Share transaction via p2p between rbuilders #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SozinM
force-pushed
the
msozin/transaction-peering
branch
from
517d77f to
0bd4761
Compare
avalonche
reviewed
Aug 8, 2025
crates/op-rbuilder/src/args/op.rs
Outdated
| pub rbuilder_peers: Vec<TrustedPeer>, | ||
|
|
||
| /// Enables transaction propagation between peers specified in builder.peers | ||
| #[arg(long = "builder.disable-txpool-gossip", default_value = "true")] |
There was a problem hiding this comment.
name should be enable? the comment says this enabled the transaction propagation
There was a problem hiding this comment.
i'm refactoring cli options ATM to make them less confusing
SozinM
force-pushed
the
msozin/transaction-peering
branch
2 times, most recently
from
7c74f59 to
9c3bbb7
Compare
SozinM
force-pushed
the
msozin/transaction-peering
branch
from
9c3bbb7 to
736c35a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR introduces private transaction propagation.
I've added flags
--builder.transaction-peers - used to specify which peers would receive transactions
Intended usage:
--rollup.disable-tx-pool-gossip = true
--builder.peers = Vec
We should always disable regular txpool gossip, to ensure that if for some reason out custom impl was removed it won't result in transaction leak.
--builder.peers should contain enode for trusted private peers only with disabled tx-pool-gossip. They all should have the same options like specified above.
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test