Fix bundle state and produce executed block #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right now it has consensus error
2025-08-01T16:10:44.956046Z ERROR engine::persistence: Persistence service failed err=ProviderError(Database(Write(DatabaseWriteError { info: DatabaseErrorInfo { message: "the given key value is mismatched to the current cursor position", code: -30418 }, operation: CursorAppendDup, table_name: "AccountChangeSets", key: [0, 0, 0, 0, 0, 0, 0, 9] })))
avalonche
reviewed
Aug 4, 2025
avalonche
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Executed block to the OpBuilderPayload.
Previously we were setting in to None.
Changes made: we were performing merge_transitions multiple times, that was the reason for not using executed block, because it was messing with trie_outputs.
I've made the following:
In the beginning of the build_block we are saving the current transition state.
Then we merge them and produce bundle
In the end of the function we are cleaning up the bundle and return back old transition state.
Another change is that we don't send flashblock and don't update best_payload if we receive engine_getPayload
📝 Summary
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test