ci-automation: explicitly make packages tarballs readable #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
force-pushed
the
dongsu/zstd-file-perm
branch
from
a6db9f3 to
77309a6
Compare
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/5833283199 |
|
CI passed, and tarballs on bincache are created with mode 0644 as expected. |
krnowak
approved these changes
Aug 11, 2023
Since #950 was merged, tarball files `flatcar-{packages,sdk}-*.tar.zst` have been created with mode 0600 instead of 0644. As a result, the files with mode 0600 were uploaded to bincache, but afterwards `copy-to-origin.sh` that in turn runs rsync from bincache to the origin server could not read the tarballs. To fix that, it is necessary to chmod from 0600 to 0644 to make it readable by rsync during the release process. All of that happens because zstd sets the mode of the output file to 0600 in case of temporary files to avoid race condition. See also facebook/zstd#1644, facebook/zstd#3432.
dongsupark
force-pushed
the
dongsu/zstd-file-perm
branch
from
77309a6 to
19e10e7
Compare
dongsupark
had a problem deploying
to
development
GitHub Actions
Failure
|
Updated commit message, description. |
|
cherry-picked to flatcar-3689 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #950 was merged, tarball files
flatcar-{packages,sdk}-*.tar.zsthave been created with mode 0600 instead of 0644.As a result, the files with mode 0600 were uploaded to bincache, but afterwards
copy-to-origin.shthat in turn runs rsync from bincache to the origin server could not read the tarballs.To fix that, it is necessary to chmod from 0600 to 0644 to make it readable by rsync during the release process.
All of that happens because zstd sets the mode of the output file to 0600 in case of temporary files to avoid race condition.
See also facebook/zstd#1644, facebook/zstd#3432.
/update-sdk
Testing done
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/985/cldsv/
changelog/directory (user-facing change, bug fix, security fix, update) (not needed)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.