Query name owners just once #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all clients connecting to the proxy share the same policy filters, we can setup the name owner data just once, when the first client connects, and store it in the FlatpakProxy object so that all other clients can use it. This avoid duplicating the calls to ListNames and GetNameOwner. Fixes: flatpak#55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all clients connecting to the proxy share the same policy filters, we can setup the name owner data just once, when the first client connects, and store it in the FlatpakProxy object so that all other clients can use it.
This avoid duplicating the calls to ListNames and GetNameOwner.
Fixes: #55
Note: this works in my setup, but I wonder if I should call
stop_reading()at the end ofgot_buffer_from_client()when thename_owners_stateisNAME_OWNERS_WAITINGand reinstate the reading once the state reachesNAME_OWNERS_READY; the comment on this invocation ofstop_reading()seems to hint that we are just worried about the ordering of the serial numbers, so it should be fine like this, but I'm not sure.