Skip to content

fine tuning the cython-linter + fix W391 code #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2024
Merged

fine tuning the cython-linter + fix W391 code #206

merged 2 commits into from
Aug 31, 2024

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Aug 31, 2024 •
edited
Loading

  • using just python 3.12
  • removing E701 and E703, E302,E303,E306 from ignored, already fixed
  • removing W391 too, fixed here

@oscarbenjamin
Copy link
Collaborator

Looks good. Thanks!

@oscarbenjamin oscarbenjamin merged commit 618bedf into flintlib:master Aug 31, 2024
39 checks passed
@oscarbenjamin
Copy link
Collaborator

Some of these could be fixed by the script mentioned #191 (comment) which we should probably include as bin/lint_fix.py or something.

@fchapoton fchapoton deleted the fine_tuning_lint branch August 31, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchapoton @oscarbenjamin