Skip to content

fix: Use nmod_mat_set_entry rather than internals #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: Use nmod_mat_set_entry rather than internals #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/flint/types/nmod_mat.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ cdef class nmod_mat(flint_mat):
row = val[i]
for j from 0 <= j < n:
x = nmod(row[j], mod)
self.val.rows[i][j] = (<nmod>x).val
nmod_mat_set_entry(self.val, i, j, x.val)
else:
raise TypeError("cannot create nmod_mat from input of type %s" % type(val))
elif len(args) == 2:
Expand All @@ -134,7 +134,7 @@ cdef class nmod_mat(flint_mat):
for i from 0 <= i < m:
for j from 0 <= j < n:
x = nmod(entries[i*n + j], mod) # XXX: slow
self.val.rows[i][j] = (<nmod>x).val
nmod_mat_set_entry(self.val, i, j, x.val)
else:
raise TypeError("nmod_mat: expected 1-3 arguments plus modulus")

Expand Down
Loading