Fix the case when this/root is undefined #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason I ask is because for the browser case there's already a |
|
Thanks, this is what I needed to make this package 100% compatible with react-native. I didn't notice the use I pulled your PR into mine: #134 |
|
@flitbit thanks for merging. I see the 1.0.2 tag in github, but it's not on npm? |
|
Yeah, didn't change the NPM token on the CI server, my bad. Should be published now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some combination of webpack and babel sometimes rewrites
thistovoid 0:Why is this line
root.DeepDiff = accumulateDiff;needed at all, could it be removed?