Skip to content

bugfix: fix DiagnosticId for AssertIsFalse & AssertIsTrue #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2023
Merged

bugfix: fix DiagnosticId for AssertIsFalse & AssertIsTrue #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
969cc1b
#160 fix DiagnosticId for AssertIsFalse & AssertIsTrue
Meir017 Oct 3, 2023
04d5521
verify code-fixer diagnistics matches code analyzer
Meir017 Oct 3, 2023
8e873f0
fix AssertNotEqualCodeFix FixableDiagnosticIds
Meir017 Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/FluentAssertions.Analyzers.Tests/DiagnosticVerifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ private static void VerifyFix(string language, DiagnosticAnalyzer analyzer, Code
}
}

codeFixProvider.FixableDiagnosticIds.Should().BeEquivalentTo(analyzer.SupportedDiagnostics.Select(d => d.Id));

//after applying all of the code fixes, compare the resulting string to the inputted one
var actual = GetStringFromDocument(document);
actual.Should().Be(newSource);
Expand Down
2 changes: 1 addition & 1 deletion src/FluentAssertions.Analyzers/Tips/MsTest/AssertIsFalse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public AssertIsFalseSyntaxVisitor() : base(new MemberValidator("IsFalse"))
[ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(AssertIsFalseCodeFix)), Shared]
public class AssertIsFalseCodeFix : MsTestAssertCodeFixProvider
{
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(CollectionShouldBeEmptyAnalyzer.DiagnosticId);
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(AssertIsFalseAnalyzer.DiagnosticId);

protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
=> RenameMethodAndReplaceWithSubjectShould(expression, "IsFalse", "BeFalse");
Expand Down
2 changes: 1 addition & 1 deletion src/FluentAssertions.Analyzers/Tips/MsTest/AssertIsTrue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public AssertIsTrueSyntaxVisitor() : base(new MemberValidator("IsTrue"))
[ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(AssertIsTrueCodeFix)), Shared]
public class AssertIsTrueCodeFix : MsTestAssertCodeFixProvider
{
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(CollectionShouldBeEmptyAnalyzer.DiagnosticId);
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(AssertIsTrueAnalyzer.DiagnosticId);

protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
=> RenameMethodAndReplaceWithSubjectShould(expression, "IsTrue", "BeTrue");
Expand Down
2 changes: 1 addition & 1 deletion src/FluentAssertions.Analyzers/Tips/Xunit/AssertNotEqual.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public AssertObjectNotEqualSyntaxVisitor() : base(
[ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(AssertNotEqualCodeFix)), Shared]
public class AssertNotEqualCodeFix : XunitCodeFixProvider
{
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(AssertEqualAnalyzer.DiagnosticId);
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(AssertNotEqualAnalyzer.DiagnosticId);

protected override ExpressionSyntax GetNewExpression(
ExpressionSyntax expression,
Expand Down