-
Notifications
You must be signed in to change notification settings - Fork 51
Publish packages automatically after merge #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish packages automatically after merge #394
Conversation
- Correct repository url. - Add missing copyright notice.
7f66da6
to
2c23fd9
Compare
79c0d06
to
29c3806
Compare
29c3806
to
1d62693
Compare
We can put off setting PUB_CREDENTIALS to Github secrets and first see if the workflow runs correctly on the master branch, if it does, we can rerun the job after adding PUB_CREDENTIALS. I see
|
The flutter team allowed neutral conclusion due to Cirrus CI, it shouldn't be a problem on our side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise overall looks good. Thank you!
@HakkyuKim You can test the push event with this PR: #392 |
@swift-kim |
eb6ea30
to
e3ea847
Compare
https://github.com/flutter-tizen/plugins/runs/6586016243 The publication was successful after updating PUB_CREDENTIALS. |
Closes #378.
Summary
For pull requests events:
pubspec.yaml
changed.pub publish --dry-run
to make CI fail on any errors or warnings. For example, missing a corresponding version entry inCHANGELOG.md
.For push events on master branch:
release
workflow until all other workflows are finished.pub publish --dry-run
again just in case.Prerequisite
The content of the
credential.json
, which is created when runningdart pub login
, must be added to Github repository secrets with name "PUB_CREDENTIALS".Limitation
New packages must be published manually because pub.dev current doesn't support publishing a new package directly to a verified publisher, See https://dart.dev/tools/pub/publishing#publishing.
TODO
release
is the last workflow to be finished.