Skip to content

Add a encrypted video stream for integration test of video_player's iOS 16 bug #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Sep 21, 2022

This is for integration test of the video_player's iOS 16 bug. Will be used in flutter/plugins#6442.

The key is generated using:

openssl rand 16 > encrypted_bee.key

The key_info is (used locally for the ffmpeg cmd only):

https://flutter.github.io/assets-for-api-docs/assets/videos/hls/encrypted_bee.key
encrypted_bee.key

And the m3u8 is created using:

ffmpeg -i bee.mp4 -g 60 -hls_time 2 -hls_list_size 0 -hls_segment_size 500000 -hls_key_info_file key_info encrypted_bee.m3u8

List which issues are fixed by this PR. You must list at least one issue.

flutter/flutter#111457

Also fixes flutter/flutter#112114

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@@ -0,0 +1,2 @@
���k
hw't6���
Copy link
Contributor Author

@hellohuanlin hellohuanlin Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a random key, generated with

openssl rand 16 > encrypted_bee.key

@jmagman
Copy link
Member

jmagman commented Sep 21, 2022

See also #178 for similar PR.

Analyzer warnings are unrelated, filed flutter/flutter#112114

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once analyzer is happy on deprecated usage

@hellohuanlin hellohuanlin force-pushed the add_encrypted_video_stream_m3u8_for_video_player_integration_tests branch from a7fc6c6 to c6f4e51 Compare September 22, 2022 17:09
@hellohuanlin
Copy link
Contributor Author

theres no autosubmit label. i will just manually land it

@hellohuanlin hellohuanlin merged commit 109051a into flutter:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings in assets-for-api-docs repo: 'headline4' is deprecated, 'bodyText2' is deprecated
2 participants