Suppress Windows specific Clang warnings and treat the rest as errors. #381
Conversation
This should also eliminate the pages and pages of warnings generated when compiling using Clang on Windows.
There was a problem hiding this comment.
I don't think we should make most of these changes.
flutter/flutter#59199 tracks the status, and all but a very small number have fixes in flight.
| ] | ||
| # Warns when a source file doesn't have a newline at end-of-file. | ||
| # This is to match Fuchsia, which enables this warning. | ||
| "-Wnewline-eof", |
There was a problem hiding this comment.
I have a fix for this landed in ANGLE, I just need to find time to update the licenses to roll it (flutter/engine#19105)
| if (!is_win) { | ||
| cflags = [ | ||
| # Warns when a const char[] is converted to bool. | ||
| "-Wstring-conversion", |
There was a problem hiding this comment.
Do we actually hit this on Windows?
| @@ -78,6 +78,8 @@ config("compiler") { | |||
| "/GS", # Enable buffer security checking. | |||
| "/FS", # Preserve previous PDB behavior. | |||
| ] | |||
|
|
|||
| ldflags += [ "/ignore:4217" ] | |||
There was a problem hiding this comment.
This needs a comment; I'm not sure what it is, or why we need to suppress it instead of fix it.
| @@ -535,6 +538,8 @@ config("runtime_library") { | |||
| "_CRT_SECURE_NO_DEPRECATE", | |||
| "_HAS_EXCEPTIONS=0", | |||
| "_SCL_SECURE_NO_DEPRECATE", | |||
| "_CRT_NONSTDC_NO_WARNINGS", | |||
| "_CRT_NONSTDC_NO_DEPRECATE", | |||
There was a problem hiding this comment.
We should't blank-suppress these. They are almost all from Dart, and they have an in-progress PR to fix them.
| # Some third party dependencies like ICU add flags that are not supported | ||
| # by clang-cl yet. | ||
| "-Wno-unknown-argument", | ||
|
|
||
| "-Wno-nonportable-include-path", | ||
| "-Wno-nonportable-system-include-path", |
There was a problem hiding this comment.
Why are you turning these on more often? The are working around a goma bug.
There was a problem hiding this comment.
I ran into these on my non-corp workstation without goma setup.
|
Great. I didn't realize you were already working on it. It was quite painful working on Windows with all the warnings so added |
This should also eliminate the pages and pages of warnings generated when
compiling using Clang on Windows.