doc: Use GoRouter state.uri.queryParameters #1876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinVignal
commented
Sep 19, 2023
| path: 'forgot-password', | ||
| builder: (context, state) { | ||
| final arguments = state.queryParameters; | ||
| final arguments = state.uri.queryParameters; |
There was a problem hiding this comment.
Above this code block there is the line:
#### [lib/main.dart](https://github.com/flutter/codelabs/blob/master/firebase-get-to-know-flutter/step_05/lib/main.dart#L23)Which redirects to https://github.com/flutter/codelabs/blob/master/firebase-get-to-know-flutter/step_05/lib/main.dart#L23 which still contains state.queryParameters. Should I change the links in this file to https://github.com/flutter/codelabs/blob/main which contains the updated code?
There was a problem hiding this comment.
Yes, please make the change.
There was a problem hiding this comment.
Sure, I made the change in doc: Redirect to main instead of master
|
How could I write a test for this change? |
|
PTAL @ericwindmill |
ericwindmill
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to flutter/packages#4881 and flutter/flutter#133773
This updates the documentation to the latest
go_routerversion by usingstate.uri.queryParametersinstead ofstate.queryParameters.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.