Skip to content

Sent event to dwds from Inspector window #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
annagrin opened this issue Feb 18, 2022 · 1 comment · Fixed by #3834
Closed

Sent event to dwds from Inspector window #3711

annagrin opened this issue Feb 18, 2022 · 1 comment · Fixed by #3834
Assignees
@annagrin
Labels
bug Something isn't working fix it friday
Milestone
On Deck

Comments

@annagrin
Copy link
Contributor

annagrin commented Feb 18, 2022 •
edited
Loading

Currently DevTools sends an event to dwds from Debugger window. Tools that start DevTools use this information to measure startup times of DevTools.

devtools/packages/devtools_app/lib/src/debugger/debugger_screen.dart

Line 158 in a616832

serviceManager.sendDwdsEvent(

For flutter apps, however, the first tab that opens is the Inspector, which means the time to start DevTools is measured incorrectly.

Related: dart-lang/webdev#1517
@jacob314 jacob314 added the bug Something isn't working label Feb 23, 2022
@jacob314 jacob314 added this to the On Deck milestone Feb 23, 2022
@jacob314
Copy link
Contributor

Fyi @elliette

@annagrin annagrin self-assigned this Mar 9, 2022
annagrin pushed a commit to annagrin/devtools that referenced this issue Mar 11, 2022
Send pageReady event to dwds from Inspector page
a1cfeda 
Send `pageReady` event from the Inspectore page, similar to what is already
done fron the Debugger page.

Closes: flutter#3711
@annagrin annagrin mentioned this issue Mar 11, 2022
Merged
annagrin pushed a commit that referenced this issue Mar 16, 2022
Send pageReady event to dwds from Inspector page (#3834)
6a61d1e 
* Send pageReady event to dwds from Inspector page

Send `pageReady` event from the Inspectore page, similar to what is already
done fron the Debugger page.

Closes: #3711

* Addressed CR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annagrin annagrin

Labels
bug Something isn't working fix it friday
Projects
None yet
Milestone
On Deck
Development

Successfully merging a pull request may close this issue.

Send pageReady event to dwds from Inspector page annagrin/devtools
2 participants
@jacob314 @annagrin