Skip to content

remove package meta dependency and imports #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import 'dart:async';

import 'package:meta/meta.dart';
import 'package:flutter/foundation.dart';

import '../../devtools.dart' as devtools show version;
import '../config_specific/import_export/import_export.dart';
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/lib/src/framework_controller.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import 'dart:async';

import 'package:meta/meta.dart';
import 'package:flutter/foundation.dart';

import 'globals.dart';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import 'dart:collection';
import 'dart:math' as math;

import 'package:meta/meta.dart';
import 'package:flutter/foundation.dart';

import '../../charts/flame_chart.dart';
import '../../profiler/cpu_profile_model.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import 'dart:collection';
import 'dart:math' as math;

import 'package:flutter/foundation.dart';
import 'package:meta/meta.dart';

import '../charts/flame_chart.dart';
import '../profiler/cpu_profile_model.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
import 'dart:collection';
import 'dart:convert';

import 'package:flutter/cupertino.dart';
import 'package:meta/meta.dart';
import 'package:flutter/foundation.dart';

import '../charts/flame_chart.dart';
import '../trace_event.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// found in the LICENSE file.

import 'package:flutter/foundation.dart';
import 'package:meta/meta.dart';

import '../globals.dart';
import '../vm_flags.dart' as vm_flags;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// found in the LICENSE file.

import 'package:collection/collection.dart';
import 'package:meta/meta.dart';
import 'package:flutter/foundation.dart';
import 'package:vm_service/vm_service.dart';

import '../../eval_on_dart_library.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// found in the LICENSE file.

import 'package:collection/collection.dart';
import 'package:meta/meta.dart';
import 'package:flutter/foundation.dart';
import 'package:vm_service/vm_service.dart' hide SentinelException;

import '../../eval_on_dart_library.dart';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import 'dart:async';

import 'package:flutter/foundation.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:meta/meta.dart';
import 'package:vm_service/vm_service.dart';

import '../eval_on_dart_library.dart';
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/lib/src/vm_service_wrapper.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import 'dart:async';

import 'package:dds/vm_service_extensions.dart';
import 'package:meta/meta.dart';
import 'package:flutter/foundation.dart';
import 'package:vm_service/vm_service.dart';

import 'globals.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import 'package:devtools_app/src/debugger/debugger_model.dart';
import 'package:devtools_app/src/globals.dart';
import 'package:devtools_app/src/service_manager.dart';
import 'package:devtools_test/mocks.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:meta/meta.dart';
import 'package:mockito/mockito.dart';
import 'package:vm_service/vm_service.dart';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import 'package:devtools_test/cli_test_driver.dart';
import 'package:devtools_test/devtools_server_driver.dart';
import 'package:devtools_test/file_utils.dart';
import 'package:devtools_test/utils.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:meta/meta.dart';
import 'package:vm_service/vm_service.dart';

import 'integration.dart';
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/test/span_parser_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import 'dart:convert';
import 'dart:io';

import 'package:devtools_app/src/debugger/span_parser.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:meta/meta.dart';

const helloWorld = '''
void main() {
Expand Down
3 changes: 0 additions & 3 deletions packages/devtools_test/lib/wrappers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import 'package:devtools_app/devtools_app.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:meta/meta.dart';
import 'package:provider/provider.dart';

import 'mocks.dart';
Expand Down Expand Up @@ -104,7 +103,6 @@ Widget wrapWithInspectorControllers(Widget widget) {

/// Call [testWidgets], allowing the test to set specific values for app globals
/// ([MessageBus], ...).
@isTest
void testWidgetsWithContext(
String description,
WidgetTesterCallback callback, {
Expand All @@ -130,7 +128,6 @@ void testWidgetsWithContext(
}

/// Runs a test with the size of the app window under test to [windowSize].
@isTest
void testWidgetsWithWindowSize(
String name,
Size windowSize,
Expand Down
1 change: 0 additions & 1 deletion packages/devtools_test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ dependencies:
sdk: flutter
flutter_test:
sdk: flutter
meta: ^1.3.0
mockito: ^5.0.9
path: ^1.8.0
pedantic: ^1.11.0
Expand Down