This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use simarm_x64 when targeting arm #10010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamappelbe
changed the title
liamappelbe
added a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2019
* Remove multi-arch check in iOS builds * Manual roll of flutter/engine#10010
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 2, 2019
[email protected]:flutter/engine.git/compare/bf9288597586...eac7ef0 git log bf92885..eac7ef0 --no-merges --oneline 2019-08-01 [email protected] Add copy_gen_snapshots.py tool (flutter/engine#10430) 2019-08-01 [email protected] Fix mac gen_snapshot uploader (flutter/engine#10423) 2019-08-01 [email protected] Make kernel compiler use host toolchain (flutter/engine#10419) 2019-08-01 [email protected] Use simarm_x64 when targeting arm (flutter/engine#10010) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Aug 8, 2019
* GN changes for simarm_x64 * GN changes for simarm_x64 * Cleanup a bit * Guard simarm_x64 behind a flag * Remove flag * Remove Mac specificity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
32-bit binaries are being deprecated on Mac, so when building for arm we need to use Dart's simarm_x64 mode, which builds a 64-bit version of gen_snapshot that can produce 32-bit arm AOT snapshots.
This is a breaking change, because there's a small change needed in flutter/flutter to support this: flutter/flutter#36710
Testing: I built the flutter examples in this mode using Xcode 10 and verified that they work on an iPhone 4S.
Bug: flutter/flutter#22598