This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Bump simulator version in IosUnitTests & scenario app in preparation for luci xcode 11 migration #15154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
commented
Jan 6, 2020
| @@ -20,6 +20,8 @@ | |||
| <string>1</string> | |||
| <key>LSRequiresIPhoneOS</key> | |||
| <true/> | |||
| <key>UILaunchStoryboardName</key> | |||
There was a problem hiding this comment.
For some reason if I take this line out, on iOS 13 XCUIScreenshot captures the status bar.
dnfield
approved these changes
Jan 6, 2020
…_simulator_version
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2020
…aration for luci xcode 11 migration (flutter/engine#15154)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 8, 2020
flutter/engine@f001ea2...46adf73 git log f001ea2..46adf73 --first-parent --oneline 2020-01-08 [email protected] Made it so you can specify the old gen heap size. (flutter/engine#15259) 2020-01-08 [email protected] Roll fuchsia/sdk/core/mac-amd64 from gL-XG... to rTJJV... (flutter/engine#15308) 2020-01-08 [email protected] Add a deprecation javadoc note to the old FlutterActivity (flutter/engine#15156) 2020-01-08 [email protected] Bump simulator version in IosUnitTests & scenario app in preparation for luci xcode 11 migration (flutter/engine#15154) 2020-01-08 [email protected] Roll src/third_party/skia 91e0d7526944..f811fc331a14 (32 commits) (flutter/engine#15306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
bkonyi
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 9, 2020
flutter/engine@f001ea2...46adf73 git log f001ea2..46adf73 --first-parent --oneline 2020-01-08 [email protected] Made it so you can specify the old gen heap size. (flutter/engine#15259) 2020-01-08 [email protected] Roll fuchsia/sdk/core/mac-amd64 from gL-XG... to rTJJV... (flutter/engine#15308) 2020-01-08 [email protected] Add a deprecation javadoc note to the old FlutterActivity (flutter/engine#15156) 2020-01-08 [email protected] Bump simulator version in IosUnitTests & scenario app in preparation for luci xcode 11 migration (flutter/engine#15154) 2020-01-08 [email protected] Roll src/third_party/skia 91e0d7526944..f811fc331a14 (32 commits) (flutter/engine#15306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…aration for luci xcode 11 migration (flutter/engine#15154)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…aration for luci xcode 11 migration (flutter/engine#15154)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…aration for luci xcode 11 migration (flutter/engine#15154)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…aration for luci xcode 11 migration (flutter/engine#15154)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…aration for luci xcode 11 migration (flutter/engine#15154)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…aration for luci xcode 11 migration (flutter/engine#15154)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…aration for luci xcode 11 migration (flutter/engine#15154)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…aration for luci xcode 11 migration (flutter/engine#15154)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2020
…aration for luci xcode 11 migration (flutter/engine#15154)
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…for luci xcode 11 migration (flutter#15154)
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…aration for luci xcode 11 migration (flutter#15154)" (flutter#15313) This reverts commit 3a9121b.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
… in preparation for luci xcode 11 migration (flutter#15154)" (flutter#15313)" This reverts commit 4e0a12c.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…aration for luci xcode 11 migration (flutter#15154)" This reverts commit 0e5624f.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
…for luci xcode 11 migration (flutter#15154)
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
…aration for luci xcode 11 migration (flutter#15154)" (flutter#15313) This reverts commit 3a9121b.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update simulator used in IosUnitTests and scenario app tests for re-landing https://github.com/flutter/infra/pull/62.
Expect the tests to fail until Xcode is updated to 11 on luci bots, which requires this PR to reland: https://github.com/flutter/infra/pull/62
led get-builder 'luci.flutter.prod:Mac iOS Engine' | led edit -p 'git_url="https://github.com/LongCatIsLooong/engine"' -p 'git_ref="bump_ios_unittest_simulator_version"' | led edit -p '$depot_tools/osx_sdk={ "sdk_version": "11a420a" } ' | led edit-recipe-bundle | led launchpassed:https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/weiyuhuang_google.com/758584569ff1cbd991509b4affbcb94edfd5fa2c9c9fc52e23cf84482b99c213/+/annotations