Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

mikejurka
Copy link
Contributor

…ey're being recycled prematurely.

Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian
Copy link
Contributor

liyuqian commented Feb 1, 2020

You may need to rebase the change to the tip-of-tree engine in order to pass the test.

@mikejurka
Copy link
Contributor Author

OK. I'm also not sure about the performance implications of this. Probably best to talk next week.

@mikejurka mikejurka requested a review from schwa423 February 3, 2020 22:15
@iskakaushik
Copy link
Contributor

closing and reopening as #16548

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants