This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove usage of Dart_AllocateWithNativeFields from tonic #16588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API is being removed from the Dart SDK.
chinmaygarde
suggested changes
Feb 14, 2020
bkonyi
force-pushed
the
remove_dart_native_allocate
branch
from
3eec4ee to
743efd6
Compare
chinmaygarde
approved these changes
Feb 14, 2020
|
A quick audit of the existing classes that specify type info for a wrappable yielded the following list. Please ensure these have the
|
|
I think that some of these classes (e.g. These classes should not have the underscore constructor. We should also remove the |
|
Tests seem to be passing and Flutter Gallery runs without issue. I'm going to go ahead and land this (Fuchsia bot is having infra issues, so landing on red). |
|
@bkonyi the Fuchsia failures are real. This patch will not be rollable into the framework as-is. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2020
jason-simmons
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 18, 2020
* c0549fb Roll buildroot. (flutter/engine#16613) * 8b0b649 improve surface state assert error messages (flutter/engine#16595) * cd77e78 Fix drawRRect failure when shader is specified (flutter/engine#16601) * fe63094 [web] Handle alignment correctly in Paragraph.getPositionForOffset (flutter/engine#16569) * 65d1126 [web] Fixing launching Safari. This should solve the LUCI issue (flutter/engine#16590) * f88f7df [web] Unskip tests that are already passing in Safari (flutter/engine#16567) * 594f660 [shell tests] Integrate Vulkan with Shell Tests * 400ed7c Revert "[shell tests] Integrate Vulkan with Shell Tests" * 15e7f51 Implement Path extractPath, tangent APIs (flutter/engine#16599) * 4941ff7 Remove usage of Dart_AllocateWithNativeFields from tonic (flutter/engine#16588) * bb01cb7 Roll fuchsia/sdk/core/linux-amd64 from Bmq1m... to J-_s6... (flutter/engine#16592)
dnfield
added a commit
that referenced
this pull request
Feb 19, 2020
)" This reverts commit 4941ff7.
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This API is being removed from the Dart SDK.
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…tter#16588)" (flutter#16684) This reverts commit 4941ff7.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…nic (flutter#16588)" (flutter#16684)" This reverts commit bfdbe07.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…tter#16588)" This reverts commit 901d380.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is being removed from the Dart SDK.