This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use the standard [[nodiscard]] attribute instead of an FML macro. #17100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FML_WARN_UNUSED_RESULT macro was necessary before C++17 when the [[nodiscard]] attribute became standard. The macro was also not supported on Windows. All platforms supported by Flutter use toolchains > C++17. Avoid the legacy macro.
|
This is part of a series of patches removing code that was relevant only for legacy C++ versions. |
jason-simmons
approved these changes
Mar 11, 2020
chinmaygarde
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FML_WARN_UNUSED_RESULT macro was necessary before C++17 when the
[[nodiscard]] attribute became standard. The macro was also not supported on
Windows. All platforms supported by Flutter use toolchains > C++17. Avoid the
legacy macro.
No functional change.