Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add logs between fuchsia test steps. #17584

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Add logs between fuchsia test steps. #17584

merged 4 commits into from
Apr 8, 2020

Conversation

godofredoc
Copy link
Contributor

Adding logs and date time in between steps will simplify finding the
steps that are failing during the fuchsia tests.

flutter/flutter#54253

Adding logs and date time in between steps will simplify finding the
steps that are failing during the fuchsia tests.

flutter/flutter#54253
@auto-assign auto-assign bot requested a review from jason-simmons April 8, 2020 04:30
@godofredoc godofredoc requested a review from dnfield April 8, 2020 17:03
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit: it may help to have the spacing on these come out the same, so they all take up the same width. But not a big deal.

@godofredoc
Copy link
Contributor Author

Done, change spacer to same lengths.

@godofredoc
Copy link
Contributor Author

Linux Android AOT Engine finished successfully but flutter/flutter#54293 prevented it to update the status.

@godofredoc godofredoc merged commit e7e4633 into flutter:master Apr 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 10, 2020
goderbauer pushed a commit to goderbauer/engine that referenced this pull request Apr 16, 2020
* Add logs between fuchsia test steps.

Adding logs and date time in between steps will simplify finding the
steps that are failing during the fuchsia tests.

flutter/flutter#54253

* Use date command instead of DATE..

* Remove extra log line.

* Same spacer lenght for all the log lines.
@godofredoc godofredoc deleted the add_more_logging branch October 18, 2021 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants