This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Eliminate verify_framework presubmit step #17617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally added in 3c1c3e2 as a means of avoiding running framework tests if they're known to be failing, but given how flaky Cirrus infrastructure has historically been, the number of false positives is too high.
chinmaygarde
approved these changes
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
This was originally added in 3c1c3e2 as a means of avoiding running framework tests if they're known to be failing, but given how flaky Cirrus infrastructure has historically been, the number of false positives is too high.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally added in 3c1c3e2 as
a means of avoiding running framework tests if they're known to be
failing, but given how flaky Cirrus infrastructure has historically
been, the number of false positives is too high.