Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented May 12, 2020

@robert-ancell robert-ancell marked this pull request as draft May 12, 2020 22:03
@auto-assign auto-assign bot requested a review from cbracken May 12, 2020 22:05
@robert-ancell
Copy link
Contributor Author

This will fix flutter/flutter#54857.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick first pass on structure.

@robert-ancell robert-ancell force-pushed the linux-shell-fl-platform-channel branch 3 times, most recently from 50a5be7 to e7d0ffc Compare May 20, 2020 02:17
@robert-ancell robert-ancell changed the title Add FlPlatformChannel Add FlPlatformPlugin May 20, 2020
@robert-ancell robert-ancell force-pushed the linux-shell-fl-platform-channel branch 2 times, most recently from 7d89ca9 to 532ed32 Compare May 27, 2020 01:55
@robert-ancell robert-ancell force-pushed the linux-shell-fl-platform-channel branch from 532ed32 to a60e62b Compare June 8, 2020 21:28
@robert-ancell robert-ancell marked this pull request as ready for review June 9, 2020 02:20
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GTK: Implement basic flutter/platform system channel
4 participants