add createOverlaySurface JNI #19040

cg021 · 2020-06-15T05:01:04Z

Description

Add JNI method createOverlaySurface for hybrid composition in the engine.

Related Issues

flutter/flutter#58288

Tests

I added the following tests:

createOverlaySurface__callsPlatformViewsController

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the contributor guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the C++, Objective-C, Java style guides for the engine.
I read the tree hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

shell/platform/android/platform_view_android_jni.h

shell/platform/android/test/io/flutter/embedding/engine/FlutterJNITest.java

blasten

LGTM

blasten · 2020-06-16T21:11:59Z

shell/platform/android/platform_view_android_jni_impl.cc

@@ -738,6 +749,14 @@ bool PlatformViewAndroid::Register(JNIEnv* env) {
    return false;
  }

+  g_create_overlay_surface_method = env->GetMethodID(


sorry, I didn't catch this one: g_create_overlay_surface_method is being set multiple times.

cg021 added 3 commits June 14, 2020 22:01

createOverlaySurface JNI

d4cabcc

update imports

c19a30b

remove unused method

69a633e

fluttergithubbot added the platform-android label Jun 15, 2020

googlebot added the cla: yes label Jun 15, 2020

cg021 requested a review from blasten June 15, 2020 16:01

cg021 mentioned this pull request Jun 15, 2020

createOverlaySurface JNI #18870

Closed

12 tasks

license

ba63b9a

cg021 force-pushed the jni-create branch from 805229c to ba63b9a Compare June 15, 2020 16:03

blasten reviewed Jun 15, 2020

View reviewed changes

shell/platform/android/platform_view_android_jni.h Outdated Show resolved Hide resolved

deleted unused file

9473188

cg021 force-pushed the jni-create branch from 26dbd80 to 9473188 Compare June 15, 2020 19:06

blasten reviewed Jun 15, 2020

View reviewed changes

shell/platform/android/test/io/flutter/embedding/engine/FlutterJNITest.java Outdated Show resolved Hide resolved

blasten reviewed Jun 15, 2020

View reviewed changes

shell/platform/android/test/io/flutter/embedding/engine/FlutterJNITest.java Outdated Show resolved Hide resolved

remove wrong function call

4187c3a

blasten approved these changes Jun 16, 2020

View reviewed changes

cg021 added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 16, 2020

blasten merged commit de06351 into flutter:master Jun 16, 2020

cg021 deleted the jni-create branch June 16, 2020 02:52

engine-flutter-autoroll mentioned this pull request Jun 16, 2020

Roll Engine from 965fbbed1776 to 469b86b0518c (70 revisions) flutter/flutter#59570

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

4d15ef6

engine-flutter-autoroll mentioned this pull request Jun 16, 2020

Roll Engine from 965fbbed1776 to 3a9674124752 (71 revisions) flutter/flutter#59580

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

625989d

engine-flutter-autoroll mentioned this pull request Jun 16, 2020

Roll Engine from 965fbbed1776 to 01e06ed3d99e (75 revisions) flutter/flutter#59593

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

76b3bf5

blasten pushed a commit to blasten/engine that referenced this pull request Jun 16, 2020

Revert add createOverlaySurface JNI flutter#19040

ec0bd30

blasten mentioned this pull request Jun 16, 2020

Revert add createOverlaySurface JNI #19040 #19075

Merged

blasten pushed a commit that referenced this pull request Jun 16, 2020

Revert add createOverlaySurface JNI #19040 (#19075)

99442c6

blasten reviewed Jun 16, 2020

View reviewed changes

engine-flutter-autoroll mentioned this pull request Jun 16, 2020

Roll Engine from 965fbbed1776 to 3d4bb12ba783 (76 revisions) flutter/flutter#59596

Closed

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to 8b7b244489c1 (86 revisions) flutter/flutter#59634

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

cbfe72d

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to e3f3fecb18cb (87 revisions) flutter/flutter#59639

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

b478384

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to b36c83756f0d (88 revisions) flutter/flutter#59644

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

1643e63

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to 43ad8347e148 (89 revisions) flutter/flutter#59652

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

92dc1ee

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to 137320b5c7a4 (90 revisions) flutter/flutter#59656

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

2a2286c

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to 9dc08393bedd (91 revisions) flutter/flutter#59660

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

09b5341

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to ef29ce68aa24 (92 revisions) flutter/flutter#59664

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

80f4457

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to f4a5f9f4486d (93 revisions) flutter/flutter#59665

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

3d7cbdf

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to c9c80011bb1f (94 revisions) flutter/flutter#59671

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

998f5da

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to 237b5f32eff8 (95 revisions) flutter/flutter#59681

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

35f2fef

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to d14958ea4db2 (103 revisions) flutter/flutter#59713

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

a773277

engine-flutter-autoroll mentioned this pull request Jun 17, 2020

Roll Engine from 965fbbed1776 to e9688f8e362a (106 revisions) flutter/flutter#59722

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

68a4c0c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

88decb3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

a4560bd

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

703c9de

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

1ef2c4e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

f0295a1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

de06351 Add createOverlaySurface JNI (flutter/engine#19040)

1111127

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add createOverlaySurface JNI #19040

add createOverlaySurface JNI #19040

cg021 commented Jun 15, 2020

blasten left a comment

blasten Jun 16, 2020

add createOverlaySurface JNI #19040

add createOverlaySurface JNI #19040

Conversation

cg021 commented Jun 15, 2020

Description

Related Issues

Tests

Checklist

Breaking Change

blasten left a comment

Choose a reason for hiding this comment

blasten Jun 16, 2020

Choose a reason for hiding this comment