This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement onDisplayPlatformView #19344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
force-pushed
the
on_display_platform_view
branch
from
b3fdb1d to
26fc606
Compare
added 2 commits
June 26, 2020 16:46
|
|
||
| /** | ||
| * The Flutter application could like dispose of an existing Android {@code View}, i.e., | ||
| * platform view. | ||
| * The Flutter application would like dispose of an existing Android {@code View} rendered in |
There was a problem hiding this comment.
typo: "would like to dispose"
| public long createVirtualDisplayForPlatformView( | ||
| @NonNull PlatformViewsChannel.PlatformViewCreationRequest request) { | ||
| // API level 20 is required for VirtualDisplay#setSurface which we use when resizing a | ||
| // platform |
There was a problem hiding this comment.
typo: put "platform view" on one line
jason-simmons
approved these changes
Jun 27, 2020
|
Merging. "Mac iOS Engine" failure is already fixed on master. |
blasten
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 29, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 29, 2020
jonahwilliams
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 29, 2020
* 1ae95f7 Roll Skia from 318afe66e699 to 63a0a758ce14 (4 revisions) (flutter/engine#19335) * b1b9469 Manual roll of Dart e24733ebd1...63cf56d925 (flutter/engine#19337) * de68a7f Roll Skia from 63a0a758ce14 to f123f06aabd6 (9 revisions) (flutter/engine#19336) * 220a831 Move fuchsia/scenic integration behind #define (flutter/engine#19003) * de74f8a migrate web engine implementation to null-safe Dart (flutter/engine#19172) * 4cd3ec0 Fix broken mac/fuchsia compiles (flutter/engine#19339) * 77e9f94 Roll Dart SDK from e24733ebd16c to 243ad5427564 (5 revisions) (flutter/engine#19338) * 4333fc3 Roll Dart SDK from 243ad5427564 to 7fc61e77e225 (5 revisions) (flutter/engine#19342) * b3cfbd2 Roll Fuchsia Mac SDK from YGK_M... to l3tHO... (flutter/engine#19343) * a28b7f0 Implement onDisplayPlatformView (flutter/engine#19344) * 1a4f38f Roll Dart SDK from 7fc61e77e225 to 871f0ee31eb0 (4 revisions) (flutter/engine#19346) * 3d61564 Roll Fuchsia Linux SDK from _d0dW... to Y_dK2... (flutter/engine#19347) * 727a38d Roll Fuchsia Mac SDK from l3tHO... to SuveI... (flutter/engine#19348) * ccfa0e7 Roll Fuchsia Linux SDK from Y_dK2... to lgSTC... (flutter/engine#19349) * 2ff740e Roll Dart SDK from 871f0ee31eb0 to f91547d6dd45 (1 revision) (flutter/engine#19350) * 692dfb3 update compilation rules for null-safety (flutter/engine#19386) * 729ca5e Roll Fuchsia Linux SDK from lgSTC... to ScRia... (flutter/engine#19389)
|
go/tested-engine-prs nag :) |
|
@xster these changes are tested via the scenario test app and e2e driver tests. Unit tests were out of scope in this change. |
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
* 1ae95f7 Roll Skia from 318afe66e699 to 63a0a758ce14 (4 revisions) (flutter/engine#19335) * b1b9469 Manual roll of Dart e24733ebd1...63cf56d925 (flutter/engine#19337) * de68a7f Roll Skia from 63a0a758ce14 to f123f06aabd6 (9 revisions) (flutter/engine#19336) * 220a831 Move fuchsia/scenic integration behind #define (flutter/engine#19003) * de74f8a migrate web engine implementation to null-safe Dart (flutter/engine#19172) * 4cd3ec0 Fix broken mac/fuchsia compiles (flutter/engine#19339) * 77e9f94 Roll Dart SDK from e24733ebd16c to 243ad5427564 (5 revisions) (flutter/engine#19338) * 4333fc3 Roll Dart SDK from 243ad5427564 to 7fc61e77e225 (5 revisions) (flutter/engine#19342) * b3cfbd2 Roll Fuchsia Mac SDK from YGK_M... to l3tHO... (flutter/engine#19343) * a28b7f0 Implement onDisplayPlatformView (flutter/engine#19344) * 1a4f38f Roll Dart SDK from 7fc61e77e225 to 871f0ee31eb0 (4 revisions) (flutter/engine#19346) * 3d61564 Roll Fuchsia Linux SDK from _d0dW... to Y_dK2... (flutter/engine#19347) * 727a38d Roll Fuchsia Mac SDK from l3tHO... to SuveI... (flutter/engine#19348) * ccfa0e7 Roll Fuchsia Linux SDK from Y_dK2... to lgSTC... (flutter/engine#19349) * 2ff740e Roll Dart SDK from 871f0ee31eb0 to f91547d6dd45 (1 revision) (flutter/engine#19350) * 692dfb3 update compilation rules for null-safety (flutter/engine#19386) * 729ca5e Roll Fuchsia Linux SDK from lgSTC... to ScRia... (flutter/engine#19389)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements onDisplayPlatformView
Related Issues
Fixes flutter/flutter#60140
Tests
I added the following tests: Scenario test app
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.