This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[WIP] Add concept of screens to engine #19425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
changed the title
gspencergoog
force-pushed
the
screens
branch
5 times, most recently
from
7dd25d7 to
e615ee5
Compare
5 tasks
gspencergoog
force-pushed
the
screens
branch
7 times, most recently
from
162d795 to
0a4fc9f
Compare
6 tasks
gspencergoog
force-pushed
the
screens
branch
10 times, most recently
from
736c894 to
dcb5537
Compare
gspencergoog
force-pushed
the
screens
branch
4 times, most recently
from
866ad76 to
363649f
Compare
gspencergoog
force-pushed
the
screens
branch
2 times, most recently
from
51d5267 to
1ed04c4
Compare
|
I'm closing this for now because it's not yet clear how to make this useful for all platforms, since some don't report window positions (UWP), and the models for displays are different between platforms. Basically, it needs some more design work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the concept of a "screen" in the engine, in preparation for multi-window support. This splits out a number of changes from the huge PR that also changes the Dart framework code to understand screens and windows. This PR just introduces screens at the engine level, and doesn't touch the dart code.
In addition, this PR creates a
ScreenMetricsclass to hold the metrics of specific screens separately from theViewportMetrics. To manage the screen metrics, aScreenclass is also added.[This PR currently contains all of the changes in https://github.com//pull/19652 as well (it's rebased on top of it), but I'll resolve those changes before submitting.]
Related Issues
Tests
PlatformConfigurationclass.Breaking Change