This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fix ios layout change cause the accessibility focus to jump randomly. #20167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
a friendly bump |
gaaclarke
approved these changes
Aug 4, 2020
gaaclarke
reviewed
Aug 4, 2020
| @@ -24,6 +24,7 @@ class AccessibilityBridgeIos { | |||
| virtual void DispatchSemanticsAction(int32_t id, | |||
| flutter::SemanticsAction action, | |||
| std::vector<uint8_t> args) = 0; | |||
| virtual void AccessibilityFocusDidChange(int32_t focused_id) = 0; | |||
There was a problem hiding this comment.
Please add a docstring, what focused_id is could be misinterpreted (it could mean the old value).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We always passes nil to layoutchange announcement and scroll announcement, this make ios to decide what to focus next by itself, and the result is unpredictable.
This pr makes accessibility bridge in ios to cache the last focused semantics object and attempt to refocus the same id after layout change or scroll to prevent a sudden jump in accessibility focus.
This is corresponding to the second problem i mentioned in flutter/flutter#62549 (comment)
Related Issues
flutter/flutter#62549
Tests
I added the following tests:
See files
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.