This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Enable more linting #20187
Merged
Enable more linting #20187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Jul 31, 2020
Comment on lines
+695
to
+696
| /* platform= */ nullptr, | ||
| /* raster= */ nullptr, |
There was a problem hiding this comment.
The C++ style is to not have the spaces between the comments: https://google.github.io/styleguide/cppguide.html#Function_Argument_Comments
I'm not sure if the linter is smart enough to handle the spaces.
There was a problem hiding this comment.
I hope it is, because the formatter is adding them =)
runtime/dart_isolate_unittests.cc
Outdated
| AddNativeCallback("NotifyNative", | ||
| CREATE_NATIVE_ENTRY(([&latch](Dart_NativeArguments args) { | ||
| CREATE_NATIVE_ENTRY(([&](Dart_NativeArguments args) { |
There was a problem hiding this comment.
FYI you can probably just capture [this], not a huge deal for tests.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2020
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 3, 2020
* 7f5d044 Wait before switching surfaces (flutter/engine#20100) * 5513273 Reland: Avoid a copy in EncodeImage (flutter/engine#20003) * 1efdd95 Roll Dart SDK from bd528bfbd69d to ea6bde577d1c (19 revisions) (flutter/engine#20172) * 3b0e697 Roll Skia from 8cc118dce813 to c3794dd52778 (27 revisions) (flutter/engine#20173) * cb1a374 Roll Fuchsia Mac SDK from T2xc0OuiK... to i0zTcQ8Qb... (flutter/engine#20175) * ed36b1a Roll Skia from c3794dd52778 to 2d01ed94605a (10 revisions) (flutter/engine#20179) * fcc1eaf Fix iOS Keyboard stuck as UIKeyboardTypeNamePhonePad (flutter/engine#20181) * 9c6837c Roll Skia from 2d01ed94605a to 7225788b9070 (6 revisions) (flutter/engine#20183) * 13e993e Fix Typos (flutter/engine#19691) * 98cfd1d Move platform specific information to `PlatformConfiguration` class (flutter/engine#19652) * 22fb58b update nullability of drawAtlas methods and flesh out docs (flutter/engine#20176) * bcc43df Roll Dart SDK from ea6bde577d1c to 033a81d924b9 (23 revisions) (flutter/engine#20186) * cb4bb93 [web] increase number of shards. sync engine web tests same as flutter repo (flutter/engine#20164) * d986b8d Enable linting in several files (flutter/engine#20134) * 7dd092d Enable more linting (flutter/engine#20187) * 3cc86ac Roll Dart SDK from 033a81d924b9 to ad5bcf16f1c8 (9 revisions) (flutter/engine#20191) * 5ca8a2a Roll Dart SDK from ad5bcf16f1c8 to d169af6f7d8f (1 revision) (flutter/engine#20192) * 4de0c04 Roll Dart SDK from d169af6f7d8f to 7e6c55e3aaf5 (1 revision) (flutter/engine#20196) * 908fe01 Fix navigation message relay. (flutter/engine#20193) * f1b3b69 Roll Dart SDK from 7e6c55e3aaf5 to 365525432a70 (2 revisions) (flutter/engine#20197) * 8fbdd3f Fix parameter names * 083282e Fix Implments typo
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
* 7f5d044 Wait before switching surfaces (flutter/engine#20100) * 5513273 Reland: Avoid a copy in EncodeImage (flutter/engine#20003) * 1efdd95 Roll Dart SDK from bd528bfbd69d to ea6bde577d1c (19 revisions) (flutter/engine#20172) * 3b0e697 Roll Skia from 8cc118dce813 to c3794dd52778 (27 revisions) (flutter/engine#20173) * cb1a374 Roll Fuchsia Mac SDK from T2xc0OuiK... to i0zTcQ8Qb... (flutter/engine#20175) * ed36b1a Roll Skia from c3794dd52778 to 2d01ed94605a (10 revisions) (flutter/engine#20179) * fcc1eaf Fix iOS Keyboard stuck as UIKeyboardTypeNamePhonePad (flutter/engine#20181) * 9c6837c Roll Skia from 2d01ed94605a to 7225788b9070 (6 revisions) (flutter/engine#20183) * 13e993e Fix Typos (flutter/engine#19691) * 98cfd1d Move platform specific information to `PlatformConfiguration` class (flutter/engine#19652) * 22fb58b update nullability of drawAtlas methods and flesh out docs (flutter/engine#20176) * bcc43df Roll Dart SDK from ea6bde577d1c to 033a81d924b9 (23 revisions) (flutter/engine#20186) * cb4bb93 [web] increase number of shards. sync engine web tests same as flutter repo (flutter/engine#20164) * d986b8d Enable linting in several files (flutter/engine#20134) * 7dd092d Enable more linting (flutter/engine#20187) * 3cc86ac Roll Dart SDK from 033a81d924b9 to ad5bcf16f1c8 (9 revisions) (flutter/engine#20191) * 5ca8a2a Roll Dart SDK from ad5bcf16f1c8 to d169af6f7d8f (1 revision) (flutter/engine#20192) * 4de0c04 Roll Dart SDK from d169af6f7d8f to 7e6c55e3aaf5 (1 revision) (flutter/engine#20196) * 908fe01 Fix navigation message relay. (flutter/engine#20193) * f1b3b69 Roll Dart SDK from 7e6c55e3aaf5 to 365525432a70 (2 revisions) (flutter/engine#20197) * 8fbdd3f Fix parameter names * 083282e Fix Implments typo
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
* 7f5d044 Wait before switching surfaces (flutter/engine#20100) * 5513273 Reland: Avoid a copy in EncodeImage (flutter/engine#20003) * 1efdd95 Roll Dart SDK from bd528bfbd69d to ea6bde577d1c (19 revisions) (flutter/engine#20172) * 3b0e697 Roll Skia from 8cc118dce813 to c3794dd52778 (27 revisions) (flutter/engine#20173) * cb1a374 Roll Fuchsia Mac SDK from T2xc0OuiK... to i0zTcQ8Qb... (flutter/engine#20175) * ed36b1a Roll Skia from c3794dd52778 to 2d01ed94605a (10 revisions) (flutter/engine#20179) * fcc1eaf Fix iOS Keyboard stuck as UIKeyboardTypeNamePhonePad (flutter/engine#20181) * 9c6837c Roll Skia from 2d01ed94605a to 7225788b9070 (6 revisions) (flutter/engine#20183) * 13e993e Fix Typos (flutter/engine#19691) * 98cfd1d Move platform specific information to `PlatformConfiguration` class (flutter/engine#19652) * 22fb58b update nullability of drawAtlas methods and flesh out docs (flutter/engine#20176) * bcc43df Roll Dart SDK from ea6bde577d1c to 033a81d924b9 (23 revisions) (flutter/engine#20186) * cb4bb93 [web] increase number of shards. sync engine web tests same as flutter repo (flutter/engine#20164) * d986b8d Enable linting in several files (flutter/engine#20134) * 7dd092d Enable more linting (flutter/engine#20187) * 3cc86ac Roll Dart SDK from 033a81d924b9 to ad5bcf16f1c8 (9 revisions) (flutter/engine#20191) * 5ca8a2a Roll Dart SDK from ad5bcf16f1c8 to d169af6f7d8f (1 revision) (flutter/engine#20192) * 4de0c04 Roll Dart SDK from d169af6f7d8f to 7e6c55e3aaf5 (1 revision) (flutter/engine#20196) * 908fe01 Fix navigation message relay. (flutter/engine#20193) * f1b3b69 Roll Dart SDK from 7e6c55e3aaf5 to 365525432a70 (2 revisions) (flutter/engine#20197) * 8fbdd3f Fix parameter names * 083282e Fix Implments typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables linting under
runtime/with some adjustments undershell/.Breaking Change
Did any tests fail when you ran them? Please read [handling breaking changes].