This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Custom Gradle home and add .vpython file #20425
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# | ||
# "vpython" specification file for build | ||
# | ||
# Pillow is required by com.facebook.testing.screenshot. | ||
|
||
python_version: "2.7" | ||
|
||
wheel: < | ||
name: "infra/python/wheels/pillow/${vpython_platform}" | ||
version: "version:6.0.0" | ||
> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
#!/bin/bash | ||
|
||
# This script is added to the PATH on LUCI when executing the junit tests. | ||
# The Python scripts used to compare the screenshots are contained in a jar file. | ||
# As a result, vpython cannot find the .vpython spec file because it's outside | ||
# of the jar file. | ||
|
||
set -e | ||
|
||
SCRIPT_DIR="$( dirname "${BASH_SOURCE[0]}" )" | ||
|
||
echo "Running from $SCRIPT_DIR/bin/python" | ||
|
||
vpython -vpython-spec "$SCRIPT_DIR/../.vpython" "$@" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was discussed with the LUCI infra folks and they said it's as better as it could get. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great to see that it worked! |
Binary file modified
BIN
-3.98 KB
(88%)
...creenshots/dev.flutter.scenariosui.PlatformTextureUiTests__testPlatformView.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-914 Bytes
(96%)
...ts/dev.flutter.scenariosui.PlatformTextureUiTests__testPlatformViewClippath.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.51 KB
(92%)
...ts/dev.flutter.scenariosui.PlatformTextureUiTests__testPlatformViewCliprect.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.59 KB
(93%)
...s/dev.flutter.scenariosui.PlatformTextureUiTests__testPlatformViewCliprrect.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3.09 KB
(89%)
...ts/dev.flutter.scenariosui.PlatformTextureUiTests__testPlatformViewMultiple.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-216 Bytes
(98%)
...riosui.PlatformTextureUiTests__testPlatformViewMultipleBackgroundForeground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7.61 KB
(85%)
...scenariosui.PlatformTextureUiTests__testPlatformViewMultipleWithoutOverlays.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.15 KB
(95%)
...ots/dev.flutter.scenariosui.PlatformTextureUiTests__testPlatformViewOpacity.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.6 KB
(89%)
...hots/dev.flutter.scenariosui.PlatformTextureUiTests__testPlatformViewRotate.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.12 KB
(84%)
...s/dev.flutter.scenariosui.PlatformTextureUiTests__testPlatformViewTransform.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4 KB
(88%)
...scenariosui.PlatformTextureUiTests__testPlatformViewTwoIntersectingOverlays.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.01 KB
(84%)
...s/screenshots/dev.flutter.scenariosui.PlatformViewUiTests__testPlatformView.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.17 KB
(85%)
...shots/dev.flutter.scenariosui.PlatformViewUiTests__testPlatformViewClippath.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.03 KB
(90%)
...shots/dev.flutter.scenariosui.PlatformViewUiTests__testPlatformViewCliprect.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3.92 KB
(87%)
...hots/dev.flutter.scenariosui.PlatformViewUiTests__testPlatformViewCliprrect.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.29 KB
(84%)
...shots/dev.flutter.scenariosui.PlatformViewUiTests__testPlatformViewMultiple.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-477 Bytes
(96%)
...enariosui.PlatformViewUiTests__testPlatformViewMultipleBackgroundForeground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-13 KB
(79%)
...er.scenariosui.PlatformViewUiTests__testPlatformViewMultipleWithoutOverlays.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.58 KB
(84%)
...nshots/dev.flutter.scenariosui.PlatformViewUiTests__testPlatformViewOpacity.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3.72 KB
(87%)
...enshots/dev.flutter.scenariosui.PlatformViewUiTests__testPlatformViewRotate.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.78 KB
(79%)
...hots/dev.flutter.scenariosui.PlatformViewUiTests__testPlatformViewTransform.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.77 KB
(85%)
...er.scenariosui.PlatformViewUiTests__testPlatformViewTwoIntersectingOverlays.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can use 3, or does that need a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin that compares the screenshots requires
python-2.7