Avoid crashing and display error if the process cannot be prepared for JIT mode Dart VM. #20980

chinmaygarde · 2020-09-03T19:10:28Z

On iOS, A FlutterEngine instantiation requires the initialization of the Dart
VM. In the debug Flutter runtime mode, a JIT mode Dart VM is created. For a
functional JIT, code pages need to be marked as executable at runtime. This is
disallowed for applications released on the iOS App Store. So, Flutter uses an
AOT mode Dart VM in the profile and release Flutter runtime modes. In the
debug mode, Flutter used to depend on enabling tracing in the process to
enable the JIT. This is the same mechanism used by debuggers. With recent
releases of iOS, this mechanism is no longer reliable when applications are
launched from the home-screen. This is not entirely surprising because the
process was using the private ptrace API to enable tracing in the process.

When tracing cannot be enabled in the process in debug runtime modes, there
used to be no error handling with the process crashing. There were no clear
messages or logs either. This patch adds said error handling. In place or the
Flutter contents, a message will be displayed saying with guidance on why the
launch failed. An appropriate log will be added as well.

To enable applications launched from the home-screen, JIT mode Dart VMs will
have to be avoided in favor of the old bytecode interpreter. That was
decommissioned because of performance and upkeep cost concerns (context in
go/decommissioning-dbc). The stakeholders in that document will have to decide
if that decision needs to be revisited given this deterioration in user
experience.

On the patch itself, in cases where tracing cannot be enabled in the process,
the FlutterEngine instantiation will return nil and log a message. A more
prominent assertion cannot be added as this will break existing applications and
take down the process. The FlutterViewController was not resilient to an
engine being nil and so had to be updated. It is unclear if I missed any spots
still because this is a change in the core assumption in the embedding
implementation. This is a best effort attempt at converting crashes to user
visible messages and logs.

Fixes flutter/flutter#62518

…r JIT mode Dart VM. On iOS, A `FlutterEngine` instantiation requires the initialization of the Dart VM. In the `debug` Flutter runtime mode, a JIT mode Dart VM is created. For a functional JIT, code pages need to be marked as executable at runtime. This is disallowed for applications released on the iOS App Store. So, Flutter uses an AOT mode Dart VM in the `profile` and `release` Flutter runtime modes. In the `debug` mode, Flutter used to depend on enabling tracing in the process to enable the JIT. This is the same mechanism used by debuggers. With recent releases of iOS, this mechanism is no longer reliable when applications are launched from the home-screen. This is not entirely surprising because the process was using the private `ptrace` API to enable tracing in the process. When tracing cannot be enabled in the process in `debug` runtime modes, there used to be no error handling with the process crashing. There were no clear messages or logs either. This patch adds said error handling. In place or the Flutter contents, a message will be displayed saying with guidance on why the launch failed. An appropriate log will be added as well. To enable applications launched from the home-screen, JIT mode Dart VMs will have to be avoided in favor of the old bytecode interpreter. That was decommissioned because of performance and upkeep cost concerns (context in go/decommissioning-dbc). The stakeholders in that document will have to decide if that decision needs to be revisited given this deterioration in user experience. On the patch itself, in cases where tracing cannot be enabled in the process, the FlutterEngine instantiation will return `nil` and log a message. A more prominent assertion cannot be added as this will break existing applications and take down the process. The `FlutterViewController` was not resilient to an engine being `nil` and so had to be updated. It is unclear if I missed any spots still because this is a change in the core assumption in the embedding implementation. This is a best effort attempt at converting crashes to user visible messages and logs. Fixes flutter/flutter#62518

flutter-dashboard · 2020-09-03T19:10:31Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

xster · 2020-09-03T19:44:23Z

runtime/dart_vm.cc

@@ -329,7 +329,12 @@ DartVM::DartVM(std::shared_ptr<const DartVMData> vm_data,
  PushBackAll(&args, kDartWriteProtectCodeArgs,
              fml::size(kDartWriteProtectCodeArgs));
 #else
-  EnsureDebuggedIOS(settings_);
+  const bool tracing_result = EnableTracingIfNecessary(settings_);
+  // This check should only trip if the embedding made no attempts enable


Sentence has some issue

xster · 2020-09-03T19:46:23Z

runtime/ptrace_check.cc

-
-  if (ptrace(PT_TRACE_ME, 0, nullptr, 0) == -1) {
+static bool EnableTracingManually(const Settings& vm_settings) {
+  if (::ptrace(PT_TRACE_ME, 0, nullptr, 0) == -1) {


Add some code comments for readers (e.g. these 2 ifs are expected to fail on iOS 14, the rest should let people jit on iOS 13 etc)

I don't think we can expect that. It's a private API and all implementation detail that can change at anytime without warning. I'd rather just be resilient to errors.

xster · 2020-09-03T19:47:05Z

runtime/ptrace_check.cc

+  return true;
+}
+
+static bool EnableTracingIfNecessaryOnce(const Settings& vm_settings) {


Why does the name have once in it? Nothing here enforces the once-ness here it seems.

Never mind, seems like the name is reflects the expectation rather than the implementation... Seems a bit strange but I don't have a strong opinion. If you expect something, you should probably assert it.

I was following the usual C convention of of calling a method that is supposed to be called when a mutex is held with the Locked suffix.

xster · 2020-09-03T20:07:25Z

runtime/ptrace_check.h

+      (FLUTTER_RUNTIME_MODE == FLUTTER_RUNTIME_MODE_DEBUG)
+
+enum class TracingResult {
+  kNotAttempted,


What part would you like clarified?

xster · 2020-09-03T20:10:27Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

+    NSLog(@"Cannot create a FlutterEngine instance in debug mode without Flutter tooling or Xcode. "
+          @"To create FlutterEngine instances from applications launched from the home-screen, use "
+          @"profile or release modes instead.");
+    [self release];


Should we assert here or do something more eye-catching than a console message?

If we assert, we will take down the process. We don't want to do that. Instead, we want to display an error message in existing applications.

xster · 2020-09-03T20:12:43Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

+    NSLog(@"Cannot create a FlutterEngine instance in debug mode without Flutter tooling or Xcode. "
+          @"To create FlutterEngine instances from applications launched from the home-screen, use "
+          @"profile or release modes instead.");
+    [self release];


@To launch in debug mode, run flutter run from Flutter tools, run from an IDE with a Flutter IDE plugin or run the iOS project from Xcode

It's implicit but we should describe the solution explicitly.

xster · 2020-09-03T20:15:58Z

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

@@ -310,8 +318,37 @@ - (void)pushRoute:(NSString*)route {

 #pragma mark - Loading the view

+static UIView* GetViewOrPlaceholder(UIView* existing_view) {


Nit: for consistency with the rest of the file, could this be an objective-c selector?

The selector will make it an instance method. This utility is not tied to any instance of the view controller.

Can't this just be a + (UIView*) getViewOrPlaceholder:?

getViewOrPlaceholder: isn't related in any way to the meta-class either. I'd rather keep it this way.

<feel free to ignore me / just water cooler chatting> isn't that generally true for most private objective-c class methods? What's the advantage for this micro-optimization?

xster · 2020-09-03T20:19:50Z

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

 - (void)loadView {
-  self.view = _flutterView.get();
+  self.view = GetViewOrPlaceholder(_flutterView.get());


This seems a bit derived. i.e. it's not a very clear, direct causation chain between the EnableTracingIfNecessary failing, the engine being nil, the view being nil etc to the ultimate text shown: "Flutter application in debug mode can only be launched from Flutter tooling or Xcode". If we show a specific solution, let's double check a specific diagnosis, i.e. engine or view is nil AND GetTracingResult failed.

Maybe checking the engine directly is a bit cleaner. Otherwise there's still an implementation leak here where the vc knows that the view implementation returns nil when the delegate is nil.

Never mind, you did inside the placeholder method. Are we adding new vectors to end up in a white placeholder view which I think shouldn't be possible before?

let's double check a specific diagnosis,

This check is being done in the method GetViewOrPlaceholder method. The comment above that check explicitly mentions the case you described.

Are we adding new vectors to end up in a white placeholder view which I think shouldn't be possible before?

I couldn't think of any but wanted to only add the message if we were sure of the cause of the failure.

xster · 2020-09-03T20:23:34Z

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

+                     project:project
+      allowHeadlessExecution:self.engineAllowHeadlessExecution]};
+
+  if (!engine) {


I think this is ok but maybe this adds maintenance cost since we have to check everywhere that we respect this new contract and we should test all of these. Could we just assert in the engine init? There's no real point limping around further if the engine can't run.

Umm I suppose the thinking here is that the user's not plugged in and will never see console logs by launching from home screen? Ya, never mind.

Could we just assert in the engine init?

We cannot assert as this will cause existing applications to crash when running on iOS 14. We limp here by displaying the placeholder.

Ya, your point about add-to-app makes sense, SG

xster · 2020-09-03T20:25:19Z

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

+    messageLabel.autoresizingMask =
+        UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
+    messageLabel.text =
+        @"Flutter application in debug mode can only be launched from Flutter tooling "


IDEs with Flutter plugins

xster · 2020-09-03T20:28:23Z

Approach LG. We should add some tests to FlutterViewControllerTest, FlutterEngineTest etc by injecting mock values.

chinmaygarde · 2020-09-03T20:44:05Z

by injecting mock values.

Where and what would I assert?

xster · 2020-09-03T20:52:03Z

Where and what would I assert?

Do you mean where to inject the test only mock return values for GetTracingResult or where to put the test?

I'm thinking somewhere in FlutterViewControllerTest.m, you can set something in "flutter/runtime/ptrace_check.h" then assert on the UIView's UILabel

chinmaygarde · 2020-09-03T21:06:31Z

you can set something in "flutter/runtime/ptrace_check.h" then assert on the UIView's UILabel

A single VM is launched in the process. Mocking the value in ptrace_check will cause DartVM initialization caused by other tests to fail. I can try to mock the FlutterEngine designated initializer to return nil and ensure that a placeholder is added instead of a FlutterView I suppose.

xster · 2020-09-03T21:12:09Z

A single VM is launched in the process. Mocking the value in ptrace_check will cause DartVM initialization caused by other tests to fail. I can try to mock the FlutterEngine designated initializer to return nil and ensure that a placeholder is added instead of a FlutterView I suppose.

Good point. SG for cutting in at engine level.

xster · 2020-09-03T21:41:14Z

Actually that probably doesn't work since you're still calling flutter::GetTracingResult() in your view controller code. Can't ptrace_check still work as is in the single VM session but you set and unset an override test value at the beginning and at the end of the test block?

googlebot · 2020-09-08T19:17:39Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2020-09-08T19:17:39Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

…pared for JIT mode Dart VM. (flutter/engine#20980)

* 556cb23 Roll Skia from 6763a713f957 to d91cd6b5ee2b (3 revisions) (flutter/engine#20989) * b6a3c54 Roll Fuchsia Linux SDK from A0PKwETay... to gfAt63Ezd... (flutter/engine#21005) * cceb733 Roll Fuchsia Mac SDK from sih5f60Gt... to 9pfHLZEFU... (flutter/engine#21006) * 5539820 Roll Skia from d91cd6b5ee2b to a73a84f9b8e3 (1 revision) (flutter/engine#21007) * b4cc631 Roll Dart SDK from f3a9ca88b664 to e59935669cb0 (1 revision) (flutter/engine#21008) * 6cf0cc4 Roll Skia from a73a84f9b8e3 to d0fe7d37d678 (1 revision) (flutter/engine#21011) * 5b055bb Roll Skia from d0fe7d37d678 to 611a52108b01 (2 revisions) (flutter/engine#21012) * 575a519 Enable lazy-async-stacks by-default in all modes (Take 3) (flutter/engine#20895) * 040a794 Roll Fuchsia Mac SDK from 9pfHLZEFU... to tUwahggJ8... (flutter/engine#21013) * 22cca4c Roll Dart SDK from e59935669cb0 to f745f9447ddf (1 revision) (flutter/engine#21014) * 539cb69 Roll Fuchsia Linux SDK from gfAt63Ezd... to Ta3F40BV6... (flutter/engine#21015) * 7d927dd Roll Dart SDK from f745f9447ddf to b88c06c314f4 (1 revision) (flutter/engine#21016) * 09a5bf7 Tweak the mdns error message (flutter/engine#20991) * d0d9ce6 Roll Fuchsia Linux SDK from Ta3F40BV6... to coVjRTWSf... (flutter/engine#21018) * 808bb85 Roll Fuchsia Mac SDK from tUwahggJ8... to TyNHQXzNU... (flutter/engine#21019) * 5aa6921 Roll Skia from 611a52108b01 to cd54c8385c31 (2 revisions) (flutter/engine#21021) * e7d558f Roll Dart SDK from b88c06c314f4 to 33b6c95936e0 (2 revisions) (flutter/engine#21023) * af90dd3 Roll Skia from cd54c8385c31 to c0d3495e1ee2 (12 revisions) (flutter/engine#21024) * f0fb74b Avoid crashing and display error if the process cannot be prepared for JIT mode Dart VM. (flutter/engine#20980) * 6a6c23a Roll Skia from c0d3495e1ee2 to cf1a4f50121f (6 revisions) (flutter/engine#21026) * 716dce0 Android 30r3 (flutter/engine#21025) * 7431070 Roll Dart SDK from 33b6c95936e0 to a2c9cae4dcd8 (1 revision) (flutter/engine#21027) * cef383d Roll Skia from cf1a4f50121f to 04b9443274cf (2 revisions) (flutter/engine#21028) * cf8c6b8 Update web lerpDouble to match C++ behaviour (flutter/engine#21010) * 6866675 Roll Skia from 04b9443274cf to b8ae7fa12aa0 (1 revision) (flutter/engine#21030) * c538f40 Roll Dart SDK from a2c9cae4dcd8 to ffbfa2000435 (1 revision) (flutter/engine#21031) * 89d34b0 Roll Skia from b8ae7fa12aa0 to 445c8ebcb710 (1 revision) (flutter/engine#21032) * 7766d2e Roll Fuchsia Mac SDK from TyNHQXzNU... to Phn3nF_BJ... (flutter/engine#21034) * e3de8d0 Roll Fuchsia Linux SDK from coVjRTWSf... to eBus_y4DN... (flutter/engine#21035) * beb7df5 Roll Skia from 445c8ebcb710 to f9d5940fef55 (3 revisions) (flutter/engine#21037) * f3a17b6 Roll Skia from f9d5940fef55 to 81c6d6eeb4cf (1 revision) (flutter/engine#21038) * bbcc495 Roll Dart SDK from ffbfa2000435 to 2e838b7b4503 (2 revisions) (flutter/engine#21039) * 61062fd Roll Skia from 81c6d6eeb4cf to 81606b5d9774 (5 revisions) (flutter/engine#21041) * f7c7b41 Revert "Enable lazy-async-stacks by-default in all modes (Take 3) (#20895)" (flutter/engine#21043)

lukehutch · 2024-05-28T21:42:34Z

On Flutter 3.22, this warning error does not show anymore, and instead, the app simply crashes if launched from the home screen in Debug mode, when attempting to register iOS plugins. fluttercommunity/plus_plugins#2912

flutter-dashboard bot added the platform-ios label Sep 3, 2020

auto-assign bot requested a review from gw280 September 3, 2020 19:10

googlebot added the cla: yes label Sep 3, 2020

chinmaygarde requested review from xster, jason-simmons and zanderso September 3, 2020 19:10

NOLINT the callback cache. The errors are in the header.

815ba1f

xster requested a review from gaaclarke September 3, 2020 19:43

xster reviewed Sep 3, 2020

View reviewed changes

PR comments.

ce23572

minor wording tweak

d667679

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

f0fb74b Avoid crashing and display error if the process cannot be pre…

576b727

…pared for JIT mode Dart VM. (flutter/engine#20980)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to 686667591c4d (25 revisions) flutter/flutter#65438

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

f0fb74b Avoid crashing and display error if the process cannot be pre…

9623479

…pared for JIT mode Dart VM. (flutter/engine#20980)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to c538f40d3610 (26 revisions) flutter/flutter#65445

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

f0fb74b Avoid crashing and display error if the process cannot be pre…

1a386bb

…pared for JIT mode Dart VM. (flutter/engine#20980)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to 89d34b0f38b6 (27 revisions) flutter/flutter#65452

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

f0fb74b Avoid crashing and display error if the process cannot be pre…

ebd100b

…pared for JIT mode Dart VM. (flutter/engine#20980)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to e3de8d0f15d8 (29 revisions) flutter/flutter#65457

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

f0fb74b Avoid crashing and display error if the process cannot be pre…

a8185c6

…pared for JIT mode Dart VM. (flutter/engine#20980)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to beb7df50609c (30 revisions) flutter/flutter#65470

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

f0fb74b Avoid crashing and display error if the process cannot be pre…

1374e43

…pared for JIT mode Dart VM. (flutter/engine#20980)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to f3a17b63d0fb (31 revisions) flutter/flutter#65476

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

f0fb74b Avoid crashing and display error if the process cannot be pre…

aeb0b22

…pared for JIT mode Dart VM. (flutter/engine#20980)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to bbcc495b1391 (32 revisions) flutter/flutter#65479

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

f0fb74b Avoid crashing and display error if the process cannot be pre…

2c1d328

…pared for JIT mode Dart VM. (flutter/engine#20980)

engine-flutter-autoroll mentioned this pull request Sep 9, 2020

Roll Engine from d1d848e8421e to f7c7b41f0a0c (34 revisions) flutter/flutter#65492

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2020

f0fb74b Avoid crashing and display error if the process cannot be pre…

27805bc

…pared for JIT mode Dart VM. (flutter/engine#20980)

jmagman mentioned this pull request Sep 19, 2020

Relaunching debug iOS 14 app from home shows white screen in dark mode flutter/flutter#66161

Closed

jmagman mentioned this pull request Oct 1, 2020

App crashes on launch on physical iOS 14 device in debug mode when debugger not attached, EXC_BAD_ACCESS (SIGKILL - CODESIGNING) flutter/flutter#60657

Closed

jmagman mentioned this pull request Nov 7, 2020

Disable ptrace on arm64e running iOS 14.2 and greater #22377

Closed

slava-sh mentioned this pull request Aug 25, 2021

Crash on launch in debug mode on iOS 14+ when debugger is not attached openfoodfacts/smooth-app#541

Closed

chinmaygarde deleted the ios14 branch July 7, 2022 22:15

bartekpacia mentioned this pull request Jan 27, 2023

Running the AUT in debug mode with xcodebuild doesn't work leancodepl/patrol#829

Closed

jmagman mentioned this pull request Mar 1, 2023

Appium - iOS - Building using debug-mode is not supported flutter/flutter#120789

Closed

gnprice mentioned this pull request Apr 19, 2023

[iOS] Crash in debug when opening from the home screen flutter/flutter#67624

Open

vashworth mentioned this pull request Aug 28, 2023

Long-term solution to replacing ios-deploy flutter/flutter#133465

Closed

This was referenced May 28, 2024

Plugin registration crash if registrar is null flutter/flutter#149214

Open

[Bug]: Crash on iOS fluttercommunity/plus_plugins#2912

Closed

		@@ -310,8 +318,37 @@ - (void)pushRoute:(NSString*)route {

		#pragma mark - Loading the view

		static UIView* GetViewOrPlaceholder(UIView* existing_view) {

Avoid crashing and display error if the process cannot be prepared for JIT mode Dart VM. #20980

Avoid crashing and display error if the process cannot be prepared for JIT mode Dart VM. #20980

Uh oh!

Conversation

chinmaygarde commented Sep 3, 2020

Uh oh!

flutter-dashboard bot commented Sep 3, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xster Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xster Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xster commented Sep 3, 2020

Uh oh!

chinmaygarde commented Sep 3, 2020

Uh oh!

xster commented Sep 3, 2020

Uh oh!

chinmaygarde commented Sep 3, 2020

Uh oh!

xster Sep 3, 2020 •

edited

Loading

xster Sep 3, 2020 •

edited

Loading

chinmaygarde Sep 3, 2020 •

edited

Loading