This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor platform message logic #22181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
force-pushed
the
ChannelBuffers2
branch
4 times, most recently
from
9e9bb48 to
12e38a7
Compare
|
Closes flutter/flutter#66699 |
This laids the groundwork for sending messages through ChannelBuffers with channel-specific callbacks rather than a single onPlatformMessage callback.
This allows us to remove the logic from the framework that puts data back into the channel buffers. Right now (before this PR) the logic for messages from plugins to the framework is bidirectional:
```
** *
Plugins -> Engine -> ChannelBuffers <- Framework <---+-.
| | | |
| '------> via drain ----' |
| |
'----------------- onPlatformMessage ---'
* = when the listener is null on the framework side
** = when onPlatformMessage is null
```
This ends up with weird race conditions and is generally less than completely clear. With this PR, we lay the groundwork for eventually reaching this model:
```
Plugins -> Engine -> ChannelBuffers -> Framework
```
...which is significantly simpler.
Hixie
force-pushed
the
ChannelBuffers2
branch
from
12e38a7 to
524a283
Compare
|
This is ready to go if someone LGTMs it (see #21572 for past reviews). |
zanderso
requested review from
yjbanov,
mdebbar,
gaaclarke,
nturgut and
jason-simmons
nturgut
approved these changes
Nov 3, 2020
chinmaygarde
added
the
waiting for tree to go green
|
@nturgut I'll be taking care of them in the near future. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
Fixes old TODOs originally added in #22181. The framework appears to be fully migrated off these.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This laids the groundwork for sending messages through ChannelBuffers with channel-specific callbacks rather than a single onPlatformMessage callback.
This allows us to remove the logic from the framework that puts data back into the channel buffers. Right now (before this PR) the logic for messages from plugins to the framework is bidirectional:
This ends up with weird race conditions and is generally less than completely clear. With this PR, we lay the groundwork for eventually reaching this model:
...which is significantly simpler.