Report image diff status for iOS scenario golden tests #22230

cyanglaz · 2020-10-30T17:02:34Z

Description

This helps debugging golden diff failure on CI easier.

Related Issues

N/A

Tests

I added the following tests:

This PR itself is to fix tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the contributor guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the C++, Objective-C, Java style guides for the engine.
I read the tree hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

I have submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

flutter-dashboard · 2020-10-30T17:02:36Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

fluttergithubbot · 2020-10-30T18:43:02Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite build_and_test_linux_unopt_debug has failed. Please fix the issues identified (or deflake) before re-applying this label.

cyanglaz · 2020-10-30T20:05:27Z

Landing this on red so we can get info on the test failure and fixing the flake accordingly.

…er/engine#22230)

* c597333 Roll Skia from f548a028ce70 to c21902c0d3cc (46 revisions) (flutter/engine#22224) * 37d766c Fix includes to start with shell (flutter/engine#22227) * 1ad6765 [web] Fixes canvas pixelation and overallocation due to transforms. (flutter/engine#22160) * 9f9fc1f Roll Skia from c21902c0d3cc to 9615bcf71f2a (1 revision) (flutter/engine#22226) * 0faa72e Roll Dart SDK from fed66f60a3bc to 25ef5dc559cf (1 revision) (flutter/engine#22225) * 172a393 Report image diff status for iOS scenario golden tests (flutter/engine#22230) * fddabca updating integration tests version. (flutter/engine#22235) * a36bcdc Roll Fuchsia Mac SDK from mhak7e_o6... to 8SkbMXJJ9... (flutter/engine#22231) * 6a331d3 Roll Skia from 9615bcf71f2a to d5e6368fffd0 (8 revisions) (flutter/engine#22234) * 9b34207 Fixing semantics borders on mobile web (flutter/engine#21856) * 4e9459e Refactored the FlutterEngine to make it easier to implement spawn functionality (flutter/engine#21890) * fa77e68 disable AppLifecycleTests (flutter/engine#22236) * 153775b update golden (flutter/engine#22247) * 50dbe85 [web] fix hot restart type error (flutter/engine#22248) * c8cf09a Roll Skia from d5e6368fffd0 to 7585a65ac709 (7 revisions) (flutter/engine#22237) * 68e2e46 Roll Fuchsia Mac SDK from 8SkbMXJJ9... to Pz4ZHZrUp... (flutter/engine#22246) * d3182bc Roll Dart SDK from 25ef5dc559cf to 5acb5fcf84cb (4 revisions) (flutter/engine#22243) * 9b4bb20 makes android semanticsnode to ignore hittest if it is not focusable (flutter/engine#22205) * 3c7a54e Roll Fuchsia Linux SDK from sNx8qabBn... to QqGvMWaYk... (flutter/engine#22244) * eea98b2 Roll Skia from 7585a65ac709 to dffd20efe95c (14 revisions) (flutter/engine#22250) * 46e3bba Defer Windows arrow key and delete handling (flutter/engine#22207) * 14437d6 fix _getArrayBuffer signature (flutter/engine#22251) * 8defec6 Fix nullability issue with Image.network (flutter/engine#22252) * 67d55ed Roll Dart SDK from 5acb5fcf84cb to a9d583383410 (4 revisions) (flutter/engine#22255) * 7c8f57c Report error when instantiating CanvasKit network image (flutter/engine#22159) * 9945db3 Remove the metrics task from cirrus. (flutter/engine#22240) * bd19181 Add braces on if statements to match linter style (flutter/engine#22130) * e9c62e7 do not print in _computePixelDensity (flutter/engine#22257) * 2617101 Roll Dart SDK from a9d583383410 to d2577410a501 (1 revision) (flutter/engine#22258) * 3d194fa Switch macOS embedding to proc table embedder API (flutter/engine#21811) * 31b6f0b Roll Fuchsia Mac SDK from Pz4ZHZrUp... to 6yEx5GNGG... (flutter/engine#22262) * 78a0181 Roll Fuchsia Linux SDK from QqGvMWaYk... to oLF1FW-gC... (flutter/engine#22264) * ccdb681 WeakPersistentHandle migration (flutter/engine#19843) * ce0a30c Roll Dart SDK from 52783837369d to b43baaaa477d (723 revisions) (flutter/engine#22265) * 59b01e0 [web] Fix repaint logic for cullrect,transform changes (flutter/engine#22273)

report diff

0b59ffc

google-cla bot added the cla: yes label Oct 30, 2020

cyanglaz requested a review from gaaclarke October 30, 2020 17:02

cleanup

6b3d619

cyanglaz mentioned this pull request Oct 30, 2020

Scenarios UI test PlatformViewMutationOpacityTests testPlatformView is flaky flutter/flutter#69361

Closed

gaaclarke approved these changes Oct 30, 2020

View reviewed changes

format

0d7304a

cyanglaz added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 30, 2020

fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 30, 2020

cyanglaz merged commit 172a393 into flutter:master Oct 30, 2020

cyanglaz deleted the threshold branch October 30, 2020 20:05

engine-flutter-autoroll mentioned this pull request Nov 2, 2020

Roll Engine from 346051939814 to 14437d6c0006 (22 revisions) flutter/flutter#69599

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 2, 2020

172a393 Report image diff status for iOS scenario golden tests (flutt…

4145a7f

…er/engine#22230)

engine-flutter-autoroll mentioned this pull request Nov 2, 2020

Roll Engine from 346051939814 to 8defec6e8ca1 (23 revisions) flutter/flutter#69608

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 2, 2020

172a393 Report image diff status for iOS scenario golden tests (flutt…

bc976ec

…er/engine#22230)

engine-flutter-autoroll mentioned this pull request Nov 2, 2020

Roll Engine from 346051939814 to 67d55ed42b25 (24 revisions) flutter/flutter#69613

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 2, 2020

172a393 Report image diff status for iOS scenario golden tests (flutt…

af634a8

…er/engine#22230)

jonahwilliams mentioned this pull request Nov 2, 2020

Remove usage of --enable-experiment to analysis server flutter/flutter#69614

Merged

engine-flutter-autoroll mentioned this pull request Nov 3, 2020

Roll Engine from 346051939814 to 7c8f57c07d24 (25 revisions) flutter/flutter#69623

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2020

172a393 Report image diff status for iOS scenario golden tests (flutt…

17071f0

…er/engine#22230)

engine-flutter-autoroll mentioned this pull request Nov 3, 2020

Roll Engine from 346051939814 to 26171019992a (29 revisions) flutter/flutter#69637

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2020

172a393 Report image diff status for iOS scenario golden tests (flutt…

c05ec1d

…er/engine#22230)

engine-flutter-autoroll mentioned this pull request Nov 3, 2020

Roll Engine from 346051939814 to 31b6f0b31a48 (31 revisions) flutter/flutter#69648

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2020

172a393 Report image diff status for iOS scenario golden tests (flutt…

dc4a1a4

…er/engine#22230)

engine-flutter-autoroll mentioned this pull request Nov 3, 2020

Roll Engine from 346051939814 to 78a018174088 (32 revisions) flutter/flutter#69657

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2020

172a393 Report image diff status for iOS scenario golden tests (flutt…

9620902

…er/engine#22230)

engine-flutter-autoroll mentioned this pull request Nov 3, 2020

Roll Engine from 346051939814 to ccdb6819ce53 (33 revisions) flutter/flutter#69672

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2020

172a393 Report image diff status for iOS scenario golden tests (flutt…

6731d5f

…er/engine#22230)

engine-flutter-autoroll mentioned this pull request Nov 3, 2020

Roll Engine from 346051939814 to ccdb6819ce53 (33 revisions) flutter/flutter#69692

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2020

172a393 Report image diff status for iOS scenario golden tests (flutt…

759a8d8

…er/engine#22230)

engine-flutter-autoroll mentioned this pull request Nov 3, 2020

Roll Engine from 346051939814 to 59b01e0e5a3f (35 revisions) flutter/flutter#69709

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2020

172a393 Report image diff status for iOS scenario golden tests (flutt…

36523e4

…er/engine#22230)

chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020

Report image diff status for iOS scenario golden tests (flutter#22230)

7d0cfdf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Report image diff status for iOS scenario golden tests #22230

Report image diff status for iOS scenario golden tests #22230

Uh oh!

cyanglaz commented Oct 30, 2020 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Oct 30, 2020

Uh oh!

fluttergithubbot commented Oct 30, 2020

Uh oh!

cyanglaz commented Oct 30, 2020

Uh oh!

Uh oh!

Report image diff status for iOS scenario golden tests #22230

Report image diff status for iOS scenario golden tests #22230

Uh oh!

Conversation

cyanglaz commented Oct 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Checklist

Reviewer Checklist

Breaking Change

Uh oh!

flutter-dashboard bot commented Oct 30, 2020

Uh oh!

fluttergithubbot commented Oct 30, 2020

Uh oh!

cyanglaz commented Oct 30, 2020

Uh oh!

Uh oh!

cyanglaz commented Oct 30, 2020 •

edited

Loading