External Texture support for macOS Metal #24523
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
iskakaushik
added
the
waiting for tree to go green
iskakaushik
force-pushed
the
macos-external-texture-implementation
branch
from
85eb7ec to
5fa31dd
Compare
|
before I learn Metal and etc, could you kindly tell me if this is direct GPU rendering or if it renders in GPU, copies to CPU, then renders back to GPU, like other texture implementations? |
|
There are no device-host copies.
Which ones are you referring to? |
The windows one seems to be a copy to CPU then copy back to GPU: #19405 (comment), as he said, copying a 1920x1080 frame takes some time. I want to render 20 960x640 frames at 30 frames each or something higher. It wouldn't be possible if it did copy from GPU to CPU and GPU back. It looks like #24916 does copies as well. ps: is the windows one for UWP or Win32 only? It's hard to find any information on UWP, or the state of external texture in Flutter as a whole. |
Fixes: flutter/flutter#73826