Exclude third_party/dart/third_party/devtools from the license script #25918

jason-simmons · 2021-05-04T16:57:25Z

No description provided.

flutter-dashboard · 2021-05-04T16:57:27Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

cbracken

This change LGTM but please add the rationale to the description for future archaeologists. You'll also have to update the tool hash.

fluttergithubbot · 2021-05-06T21:49:02Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Windows Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

fluttergithubbot · 2021-05-07T05:59:02Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Windows Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

fluttergithubbot · 2021-05-07T16:24:01Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

zanderso · 2021-05-07T16:32:41Z

@jason-simmons This will need a re-base to get the presubmit checks to pass.

This component will be added to the engine dependencies by flutter#25912

…e script (flutter/engine#25918)

* ccaae8d Roll Skia from 537293bf155f to adadb95a9f1e (1 revision) (flutter/engine#25905) * 2e3a7f8 Roll buildroot to pick change to cppwinrt invocation (flutter/engine#25993) * 1c22286 [Linux] revise dark theme detection (flutter/engine#25535) * 7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860) * 406c4da Ensure that AutoIsolateShutdown drops its reference to the DartIsolate on the intended task runner (flutter/engine#25899) * 72c2fda [web] Fix incorrect physical size due to visualviewport api on iOS (flutter/engine#25895) * a712ffe Roll Dart SDK from b8f4018535fa to 86c749398b3a (16 revisions) (flutter/engine#25999) * edbbb12 Roll Fuchsia Mac SDK from uQgs5ZmFq... to aCsEHpnS0... (flutter/engine#26001) * afbbeac Implement smooth resizing for Linux (flutter/engine#25884) * 3ffb8ef Roll Dart SDK from 86c749398b3a to b4210cc43086 (2 revisions) (flutter/engine#26006) * 039dcd9 pull googletest from github instead of fuchsia.googlesource (flutter/engine#25907) * 9c793f1 Roll Skia from adadb95a9f1e to 1dc2d0fe0fa0 (98 revisions) (flutter/engine#26009) * 82efb9a Roll Skia from 1dc2d0fe0fa0 to 115645ee9b1b (2 revisions) (flutter/engine#26012) * 91a4c72 Delete unused method from engine_layer.h (flutter/engine#25924) * 619f82f fuchsia: Fix multi-views fallout (flutter/engine#25984) * 0b4bf7e Fixes BUILD.gn if is_fuchsia (legacy embedder) and is_debug (flutter/engine#25858) * 2e9de09 Streamline frame timings recording (flutter/engine#25892) * 1077da8 [vsync_waiter] add AwaitVSyncForSecondaryCallback() (flutter/engine#25787) * 0053bef [build_fuchsia_artifacts] Move license copying into BuildBucket(). (flutter/engine#25815) * e8b80e7 Roll Skia from 115645ee9b1b to c411429239e9 (7 revisions) (flutter/engine#26018) * d3353b2 Move more parts to libraries. (flutter/engine#25863) * d1a1182 Roll Dart SDK from b4210cc43086 to 04e55dad908d (2 revisions) (flutter/engine#26020) * f631f5b Exclude third_party/dart/third_party/devtools from the license script (flutter/engine#25918) * 304539b Roll Fuchsia Mac SDK from aCsEHpnS0... to OyXxehV6e... (flutter/engine#26022) * c3e28ae Roll Fuchsia Linux SDK from 4numS0K6T... to -FIIsjZj2... (flutter/engine#26023) * 6cacb53 Roll Skia from c411429239e9 to 72de83df3a03 (1 revision) (flutter/engine#26024) * bfccba5 Add dependency on Windows SDK CIPD package (flutter/engine#26003) * 06cbf1e Roll Dart SDK from 04e55dad908d to 094c9024373c (1 revision) (flutter/engine#26027) * 73aaeea Roll Skia from 72de83df3a03 to dabb2891c4a1 (4 revisions) (flutter/engine#26025) * e229649 Extract Windows string_conversion target (flutter/engine#26029) * 3d73e06 Extract FML command_line target (flutter/engine#26028) * 4aace54 Make SceneBuilder.push* not return nullable objects (flutter/engine#25991) * 0d62a56 Roll Dart SDK from 094c9024373c to 2ea89ef8f6de (1 revision) (flutter/engine#26030) * 5a26c1f Use string_view inputs for conversion functions (flutter/engine#26031) * 4f28de4 Support windows registry access (flutter/engine#26032) * 234fae1 Roll Fuchsia Linux SDK from -FIIsjZj2... to KZCe5FqMb... (flutter/engine#26034) * 7a47d3b Roll Fuchsia Mac SDK from OyXxehV6e... to DSk0IzBHv... (flutter/engine#26035) * 01f9bd8 Roll Skia from dabb2891c4a1 to 686dd910dd6c (1 revision) (flutter/engine#26036) * 1825bef Revert Dart SDK to b8f4018535fa792891e2add3a475f35e3ec156ab (flutter/engine#26037)

…flutter#25918)

jason-simmons requested review from cbracken and zanderso May 4, 2021 16:57

google-cla bot added the cla: yes label May 4, 2021

bkonyi self-requested a review May 4, 2021 16:58

bkonyi approved these changes May 4, 2021

View reviewed changes

zanderso requested a review from Hixie May 4, 2021 16:59

cbracken approved these changes May 4, 2021

View reviewed changes

jason-simmons force-pushed the license_dart_devtools branch from 3eda990 to 527d9ac Compare May 4, 2021 17:30

chinmaygarde mentioned this pull request May 6, 2021

Add dart devtools to DEPS #25912

Closed

chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 6, 2021

fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 6, 2021

bkonyi added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 7, 2021

fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 7, 2021

zanderso added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 7, 2021

fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 7, 2021

Exclude third_party/dart/third_party/devtools from the license script

c0bc106

This component will be added to the engine dependencies by flutter#25912

jason-simmons force-pushed the license_dart_devtools branch from 527d9ac to c0bc106 Compare May 7, 2021 17:10

jason-simmons added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 7, 2021

fluttergithubbot merged commit f631f5b into flutter:master May 7, 2021

engine-flutter-autoroll mentioned this pull request May 7, 2021

Roll Engine from f57e986aa80c to f631f5bcb2d7 (23 revisions) flutter/flutter#82070

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 7, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

d0d9102

…e script (flutter/engine#25918)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to bfccba5ac00c (27 revisions) flutter/flutter#82079

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

a06fb12

…e script (flutter/engine#25918)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 06cbf1e0d773 (28 revisions) flutter/flutter#82083

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

acc0678

…e script (flutter/engine#25918)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 73aaeea34640 (29 revisions) flutter/flutter#82090

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

d8161a7

…e script (flutter/engine#25918)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to e229649a7a97 (30 revisions) flutter/flutter#82096

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

9310e37

…e script (flutter/engine#25918)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 4aace5476b33 (32 revisions) flutter/flutter#82097

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

957a801

…e script (flutter/engine#25918)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 0d62a560fe6a (33 revisions) flutter/flutter#82120

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

e66be8c

…e script (flutter/engine#25918)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 4f28de494253 (35 revisions) flutter/flutter#82121

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

90aef9c

…e script (flutter/engine#25918)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 234fae1b8d1d (36 revisions) flutter/flutter#82122

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

9a37f69

…e script (flutter/engine#25918)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 7a47d3b32567 (37 revisions) flutter/flutter#82127

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

5ea3efb

…e script (flutter/engine#25918)

engine-flutter-autoroll mentioned this pull request May 9, 2021

Roll Engine from f57e986aa80c to 01f9bd8649cd (38 revisions) flutter/flutter#82130

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

d763b06

…e script (flutter/engine#25918)

engine-flutter-autoroll mentioned this pull request May 9, 2021

Roll Engine from f57e986aa80c to 1825befbc72d (39 revisions) flutter/flutter#82132

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2021

f631f5b Exclude third_party/dart/third_party/devtools from the licens…

e6a1b08

…e script (flutter/engine#25918)

aam mentioned this pull request May 14, 2021

Handle .wasm files in license check script #25919

Closed

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request May 21, 2021

Exclude third_party/dart/third_party/devtools from the license script (…

63ad57f

…flutter#25918)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Exclude third_party/dart/third_party/devtools from the license script #25918

Exclude third_party/dart/third_party/devtools from the license script #25918

Uh oh!

jason-simmons commented May 4, 2021

Uh oh!

flutter-dashboard bot commented May 4, 2021

Uh oh!

cbracken left a comment •

edited

Loading

Uh oh!

fluttergithubbot commented May 6, 2021

Uh oh!

fluttergithubbot commented May 7, 2021

Uh oh!

fluttergithubbot commented May 7, 2021

Uh oh!

zanderso commented May 7, 2021

Uh oh!

Uh oh!

Exclude third_party/dart/third_party/devtools from the license script #25918

Exclude third_party/dart/third_party/devtools from the license script #25918

Uh oh!

Conversation

jason-simmons commented May 4, 2021

Uh oh!

flutter-dashboard bot commented May 4, 2021

Uh oh!

cbracken left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fluttergithubbot commented May 6, 2021

Uh oh!

fluttergithubbot commented May 7, 2021

Uh oh!

fluttergithubbot commented May 7, 2021

Uh oh!

zanderso commented May 7, 2021

Uh oh!

Uh oh!

cbracken left a comment •

edited

Loading