This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[test] Empty commit #27599
Merged
[test] Empty commit #27599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually merging. the Linux Unopt change is due to HEAD being at a bad checkout and this is an empty commit to test https://flutter-review.googlesource.com/c/infra/+/15660 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
8 tasks
cbracken
added a commit
that referenced
this pull request
Aug 10, 2021
At one point, this shard built the Android Vulkan binaries, but during the migration to ci.yaml-based recipes, the gn and build steps for that build were accidentally removed. As such, this shard no longer builds anything. This was detected when a buildroot roll triggered a clobber build which caused the verify_exported.dart script to fail due to a missing 'out' directory, which caused several of us to wonder why we were: 1. Checking that we strip release binaries on a debug bot, and 2. Why we're checking that we strip release binaries before we actually build anything at all. It appears that we used to build android vulkan binaries, such as in steps 14-16 of Build 11130: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11130/overview We migrated to ci.yaml-based infra in this commit: * https://flutter-review.googlesource.com/c/infra/+/15660 A no-op rebuild was triggered in commmit: * #27599 Which triggered the following buikld, Build 11131: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11131/overview That build does not contain the gn or build steps for the Android Vulkan binaries. HOWEVER... we have no users actually using Android Vulkan binaries, so rather than update the build to fix this, we delete the shard altogether and save some CPU. This will be followed by a patch that removes the --enable-vulkan flag from gn and throughout our build.
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
a-siva
pushed a commit
to a-siva/engine
that referenced
this pull request
Jan 26, 2022
a-siva
added a commit
that referenced
this pull request
Jan 26, 2022
* Roll Dart SDK from e256855 to a3b62f3 (4 revisions) (#21809) * Roll Dart SDK from e655b9a to b58cfe5 (1 revision) (#21920) * Roll Dart SDK from fc82eee to 8be6a08 (1 revision) (#22005) * Roll Dart SDK from fe12b05 to a188781 (1 revision) (#22379) * Roll Skia from 95b5fb9 to 68ac3b9 (17 revisions) (#22713) * Roll Dart SDK from 2c74e62 to f9760fc (5 revisions) (#22881) * Roll Dart SDK from 68d1c75 to f166571 (1 revision) (#23056) * Roll Dart SDK from 970d74c to fd72dbb (1 revision) (#23820) * Trigger an engine build to re-open the tree (#26056) This commit is empty and simply triggers a new build to open the tree. Commit 106963e was re-built after a succesful build; upload to the cloud storage bin failed. * Roll Skia from d9a7c5953df3 to 827bb729a84d (2 revisions) (#26096) * Roll Dart SDK from d616108 to a527411 (0 revision) (#26156) * Roll Dart SDK from bb9d96f to 7250fd6 (0 revision) (#26374) * Roll Dart SDK from 202c42e to 2e9c430 (1 revision) (#26578) * Roll buildroot to 275038b (#26945) * [test] empty commit (#27599) https://flutter-review.googlesource.com/c/infra/+/15660 * Roll Dart SDK from e141400 to 6860708 (1 revision) (#27620) * Empty commit to apply latest LUCI config (#27767) * Roll Dart SDK from 3b11f88 to 976f160 (3 revisions) (#29436) * Empty commit to fix main tree status (#29760) * Add option to enable serial GC This option can be used to avoid thread contention issues for the UI thread when running on low power devices with limited number of cores. * Fix format. * Added test. * Add build rule. * Address review comments. Co-authored-by: skia-flutter-autoroll <[email protected]> Co-authored-by: Chris Bracken <[email protected]> Co-authored-by: Casey Hillers <[email protected]>
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
At one point, this shard built the Android Vulkan binaries, but during the migration to ci.yaml-based recipes, the gn and build steps for that build were accidentally removed. As such, this shard no longer builds anything. This was detected when a buildroot roll triggered a clobber build which caused the verify_exported.dart script to fail due to a missing 'out' directory, which caused several of us to wonder why we were: 1. Checking that we strip release binaries on a debug bot, and 2. Why we're checking that we strip release binaries before we actually build anything at all. It appears that we used to build android vulkan binaries, such as in steps 14-16 of Build 11130: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11130/overview We migrated to ci.yaml-based infra in this commit: * https://flutter-review.googlesource.com/c/infra/+/15660 A no-op rebuild was triggered in commmit: * flutter#27599 Which triggered the following buikld, Build 11131: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11131/overview That build does not contain the gn or build steps for the Android Vulkan binaries. HOWEVER... we have no users actually using Android Vulkan binaries, so rather than update the build to fix this, we delete the shard altogether and save some CPU. This will be followed by a patch that removes the --enable-vulkan flag from gn and throughout our build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to validate the changes in https://flutter-review.googlesource.com/c/infra/+/15660. Reverting this commit will not do anything. However, if the CL needs to be reverted, this commit can also be reverted to retry the tree.
flutter/flutter#84998
Pre-launch Checklist
writing and running engine tests.
///).