This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix memory leak in PlatformViewsController #27915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
force-pushed
the
memory_leak_pvc
branch
2 times, most recently
from
891f605 to
bd5dc53
Compare
blasten
force-pushed
the
memory_leak_pvc
branch
from
bd5dc53 to
903846d
Compare
bparrishMines
approved these changes
Aug 7, 2021
| // platform view that | ||
| // it is associated with(e.g if a platform view creates other views in the same virtual display. | ||
| private final HashMap<Context, View> contextToPlatformView; | ||
| @VisibleForTesting /* package */ final HashMap<Context, View> contextToPlatformView; |
There was a problem hiding this comment.
nit: Is /* package */ necessary? This should be the implied visibility right?
There was a problem hiding this comment.
it increases readability since the Java language isn't very descriptive. Debatable, but it's commonly used in g3 as well as in the engine.
blasten
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2021
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks #27379