-
Notifications
You must be signed in to change notification settings - Fork 6k
Sets focus before sending a11y focus event in Android #27992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TestSemanticsUpdate testSemanticsUpdate = root.toUpdate(); | ||
testSemanticsUpdate.sendUpdateToBridge(accessibilityBridge); | ||
|
||
class Verifier { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is this class necessary? it could also use ArgumentCaptor
to extract AccessibilityEvent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to verify the focus is set at the exact moment the requestSendAccessibilityEvent is called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so i need a callback to run when requestSendAccessibilityEvent is called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See line 845
Hi, has this change been on stable channel already? Edit: This doesn't work on beta channel either. flutter doctor -v
|
…r#27992)" (flutter#28092) This reverts commit 56cf819.
In the original issue, the slider is not announce because android think it is not focused when it receive the focus event. This PR makes sure the a11ynodeinfo returns isAccessibilityFocus = true before sending out a11y event
Fixes flutter/flutter#79528
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.