Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix some stack-use-after-scopes found by ASan #28147

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Fix some stack-use-after-scopes found by ASan #28147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f08a86
Fix stack-use-after-scope in RefCountedTest.Swap
bdero Aug 13, 2021
9474594
Fix stack-use-after-scope in EmbedderTest.PushingMutlipleFrames*
bdero Aug 13, 2021
5542c04
Fix stack-use-after-scope in ParagraphTest.GetWordBoundaryParagraph
bdero Aug 17, 2021
08010ad
Revert "Fix stack-use-after-scope in ParagraphTest.GetWordBoundaryPar…
bdero Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fml/memory/ref_counted_unittest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,13 +472,15 @@ TEST(RefCountedTest, SelfAssignment) {

TEST(RefCountedTest, Swap) {
MyClass* created1 = nullptr;
bool was_destroyed1 = false;
static bool was_destroyed1;
was_destroyed1 = false;
RefPtr<MyClass> r1(MakeRefCounted<MyClass>(&created1, &was_destroyed1));
EXPECT_TRUE(created1);
EXPECT_EQ(created1, r1.get());

MyClass* created2 = nullptr;
bool was_destroyed2 = false;
static bool was_destroyed2;
was_destroyed2 = false;
RefPtr<MyClass> r2(MakeRefCounted<MyClass>(&created2, &was_destroyed2));
EXPECT_TRUE(created2);
EXPECT_EQ(created2, r2.get());
Expand Down
6 changes: 4 additions & 2 deletions shell/platform/embedder/tests/embedder_unittests_gl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2018,7 +2018,8 @@ TEST_F(EmbedderTest,

constexpr size_t frames_expected = 10;
fml::CountDownLatch frame_latch(frames_expected);
size_t frames_seen = 0;
static size_t frames_seen;
frames_seen = 0;
context.AddNativeCallback("SignalNativeTest",
CREATE_NATIVE_ENTRY([&](Dart_NativeArguments args) {
frames_seen++;
Expand Down Expand Up @@ -2056,7 +2057,8 @@ TEST_F(EmbedderTest,

constexpr size_t frames_expected = 10;
fml::CountDownLatch frame_latch(frames_expected);
size_t frames_seen = 0;
static size_t frames_seen;
frames_seen = 0;
context.AddNativeCallback("SignalNativeTest",
CREATE_NATIVE_ENTRY([&](Dart_NativeArguments args) {
frames_seen++;
Expand Down