Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

merge accounting of the picture and dl cache entries in reported statistics #28392

Merged

Conversation

flar
Copy link
Contributor

@flar flar commented Aug 31, 2021

We used to report separate statistics for the Picture cache and the DisplayList cache, but really they are somewhat mutually exclusive caches that are used for the same purpose. I've merged our reporting of statistics on those caches for a number of reasons:

  • Flutter developers only see the Dart "Picture" class and though we sometimes implement it using an SkPicture and sometimes using a DisplayList, that implementation detail will not be important to them
  • Developers are likely familiar with looking for picture cache statistics in various tools and may miss the DL cache statistics or misunderstand why the picture cache statistics would suddenly be different when DisplayList is enabled
  • devtools only looks for the picture cache statistics and so is not reporting any statistics for the DL cache

Now both cache statistics will be consolidated and reported under the single "picture cache" set of metrics.

@google-cla google-cla bot added the cla: yes label Aug 31, 2021
@flar flar requested review from chinmaygarde and zanderso August 31, 2021 22:35
@flar flar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 1, 2021
@fluttergithubbot fluttergithubbot merged commit 244c868 into flutter:master Sep 1, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 1, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants