Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Delete is_background_view from FlutterJNI #28566

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Delete is_background_view from FlutterJNI #28566

merged 2 commits into from
Sep 23, 2021

Conversation

ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Sep 11, 2021 •
edited
Loading

Fixes : flutter/flutter#73923

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Sep 11, 2021
dnfield
dnfield approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This may break users of e.g. the alarm plugin if they're still on the v1 embedding, but that's ok.

@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 23, 2021
@fluttergithubbot fluttergithubbot merged commit d350eb3 into flutter:master Sep 23, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 23, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 23, 2021
@engine-flutter-autoroll
d350eb3 Delete is_background_view from FlutterJNI (flutter/engine#28566)
c33b8f0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 23, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 23, 2021
@engine-flutter-autoroll
d350eb3 Delete is_background_view from FlutterJNI (flutter/engine#28566)
8eca08f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 24, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2021
@engine-flutter-autoroll
d350eb3 Delete is_background_view from FlutterJNI (flutter/engine#28566)
a780d4e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnfield dnfield dnfield approved these changes

@xster xster Awaiting requested review from xster

@blasten blasten Awaiting requested review from blasten

Assignees
No one assigned
Labels
cla: yes customer: alibaba platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete is_background_view from FlutterJNI
3 participants
@ColdPaleLight @dnfield @fluttergithubbot