-
Notifications
You must be signed in to change notification settings - Fork 6k
Remove outdated unused element suppressions #28775
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
0512351
to
99c7d7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, looks like someone fixed the bug around this :)
LGTM, I will close the upstream bug.
(this was picked as a safe PR to merge from PR triage to kick the tree, which is red on something not related to the code at head) |
Re: flutter/flutter#35164 - these seem to be recognized as used now.