This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] improve Firefox launch process #28922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
mdebbar
approved these changes
Sep 29, 2021
Comment on lines
+151
to
+156
| request.response.headers.set(HttpHeaders.contentTypeHeader, 'text/html'); | ||
| request.response.write(''' | ||
| <script> | ||
| location = ${json.encode(url.toString())}; | ||
| </script> | ||
| '''); |
There was a problem hiding this comment.
Clever!
Why not use HTTP redirect?
There was a problem hiding this comment.
Because I haven't thought of that :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completer<BrowserManager>toCompleter<BrowserManager?>. This was causing cryptic stack traces and hanging of the process. Also filed CastingFuture<Foo>toFuture<Foo?>leads to hard-to-debug errors too easily dart-lang/sdk#47308 about it.Browserretry launching the browser 3 times before giving up.This is a somewhat speculative fix for flutter/flutter#90831 (I cannot reproduce Firefox crashing locally, so I just emulated the crash)