Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[fuchsia] publish dart runner v2 protocol #28993

Merged
merged 1 commit into from
Oct 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions shell/platform/fuchsia/dart_runner/dart_runner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,13 @@ DartRunner::DartRunner(sys::ComponentContext* context) : context_(context) {
bindings_.AddBinding(this, std::move(request));
});

context_->outgoing()
->AddPublicService<fuchsia::component::runner::ComponentRunner>(
[this](fidl::InterfaceRequest<
fuchsia::component::runner::ComponentRunner> request) {
component_runner_bindings_.AddBinding(this, std::move(request));
});

#if !defined(DART_PRODUCT)
// The VM service isolate uses the process-wide namespace. It writes the
// vm service protocol port under /tmp. The VMServiceObject exposes that
Expand Down
2 changes: 2 additions & 0 deletions shell/platform/fuchsia/dart_runner/dart_runner.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ class DartRunner : public fuchsia::sys::Runner,
// Not owned by DartRunner.
sys::ComponentContext* context_;
fidl::BindingSet<fuchsia::sys::Runner> bindings_;
fidl::BindingSet<fuchsia::component::runner::ComponentRunner>
component_runner_bindings_;

#if !defined(AOT_RUNTIME)
dart_utils::MappedResource vm_snapshot_data_;
Expand Down
1 change: 0 additions & 1 deletion shell/platform/fuchsia/dart_runner/meta/common.shard.cml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
},
{
protocol: [
"fuchsia.component.runner.ComponentRunner",
"fuchsia.device.NameProvider", // For fdio uname()
"fuchsia.feedback.CrashReporter",
"fuchsia.intl.PropertyProvider", // For dartVM timezone support
Expand Down